Fix slider touch event #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit message 可以幫我改成 |
homerchen19
force-pushed
the
fix-slider
branch
from
4c1f076 to
910649a
Compare
jigsawye
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
不確定是不是個 bug～不是的話我再 close
這小問題是，如果在手機上用點的方式，component 會一直是 active 的情況，log 後發現
active的變化是true->false->true，但理想上應該是true->false就好了（這是我的想像啦ＸＤ）這是參考的解法
facebook/react#9809 (comment)
修改前：
修改後：
