Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update check to look for string 'true' not bool #60

Merged
merged 7 commits into from
Dec 20, 2024
Merged

update check to look for string 'true' not bool #60

merged 7 commits into from
Dec 20, 2024

Conversation

Alan-eMartin
Copy link
Contributor

@Alan-eMartin Alan-eMartin commented Dec 20, 2024 •
edited
Loading

Context:

  • PST theme configurations were ignored, causing command palette to appear even though it was configured to be disabled.

Description of the Change:

  • Use string values of true in XST

Benefits:

  • N/A

Possible Drawbacks:

  • N/A

Related GitHub Issues:

  • N/A

Alan-eMartin
Alan-eMartin commented Dec 20, 2024
View reviewed changes
@Alan-eMartin Alan-eMartin marked this pull request as ready for review December 20, 2024 22:20
Mandrenkov
Mandrenkov requested changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@Mandrenkov Mandrenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks good! 👍

But if we're going to skip the pre-release PR, we should also update the version in _version.py.

@Alan-eMartin
Copy link
Contributor Author

In general, looks good! 👍

But if we're going to skip the pre-release PR, we should also update the version in _version.py.

done! ty!

@Alan-eMartin Alan-eMartin merged commit c39d2d3 into master Dec 20, 2024
2 checks passed
@Alan-eMartin Alan-eMartin deleted the fix-theme-conf-bools branch December 20, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mandrenkov Mandrenkov Mandrenkov approved these changes

@ashishks0522 ashishks0522 Awaiting requested review from ashishks0522

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alan-eMartin @Mandrenkov