-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added missing variables #24
added missing variables #24
Conversation
Hello. You may have forgotten to update the changelog!
|
Have you tried building a local version of the e.g. PennyLane documentation using this version of the XST and confirmed that the expected behaviour is happening now, @LucasSilbernagel? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LucasSilbernagel! just two minor changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LucasSilbernagel I just noticed that this variable is called github_repo
here, not github_link
:
var githubLink = "https://github.com/" + "{{ theme_github_repo }}" + "/blob/master/" + tutorialUrlArray.join("/") + ".py", |
So a few suggested changes to correct this.
Co-authored-by: Josh Izaac <[email protected]>
Co-authored-by: Josh Izaac <[email protected]>
Co-authored-by: Josh Izaac <[email protected]>
Co-authored-by: Josh Izaac <[email protected]>
Co-authored-by: Josh Izaac <[email protected]>
Co-authored-by: Josh Izaac <[email protected]>
@Mandrenkov @josh146 are there instructions somewhere on how to do that? |
@LucasSilbernagel if you install this repository locally using pip ( |
Thanks @josh146 ! I think something still isn't right, the View on GitHub links still don't work. |
@LucasSilbernagel have you updated the |
@josh146 Ah okay, that worked! Do I need to open a QML PR with that change? |
@LucasSilbernagel yes please 🙂 Note that it won't work until we make a new release of XST. Do you mind updating the |
@josh146 version updated for release. Is there anything else we have to do here, or can this just be merged? |
Should be good to be merged @LucasSilbernagel :) |
Adds missing variables:
github_link
andgallery_dirs
@josh146 I don't really know what I'm doing with this, let me know if I missed anything or if there's anything else I can do to help.