Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navbar shadow for small screen widths #20

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Conversation

josh146
Copy link
Member

@josh146 josh146 commented Sep 24, 2022

Context: Existing repositories that use this theme for documentation with a global TOC have the following behaviour:

  • Width > 1500px: Navbar has a drop shadow
  • Width < 1500px: Navbar drop shadow is deactivated.

This behaviour was accidentally broken in a previous PR (#14), as the order of the CSS file was subtly changed (navbar CSS was moved to after small screen width CSS).

Description of the Change: Reverts the accidental reordering to return the original behaviour.

Benefits: Behaviour returns to v0.2

Possible Drawbacks: n/a

Related GitHub Issues: n/a

@josh146 josh146 requested a review from Mandrenkov September 24, 2022 02:29
@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name and GitHub username in the contributors section.

@josh146 josh146 requested a review from anthayes92 September 26, 2022 14:36
Copy link
Collaborator

@Mandrenkov Mandrenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice catch! 🎣

Co-authored-by: Mikhail Andrenkov <[email protected]>
@josh146 josh146 merged commit 5607fa2 into master Sep 27, 2022
@josh146 josh146 deleted the fix-navbar-shadow branch September 27, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants