Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.Data.SqlClient to version 5.2.1 #2270

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

abmaonline
Copy link
Contributor

What this PR does / why we need it:

Package update fixes a regression in the Microsoft SqlClient causing issues with linux clients (it also broke ef core connections since it started to use the broken client): https://github.com/dotnet/SqlClient/releases/tag/v5.2.1

Fixed connection errors on Linux when Data Source property contains both named instance and port dotnet/SqlClient#2436

Which issue(s) this PR fixes:

No issue yet, should I create an issue first?

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

No

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Collaborator

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution @abmaonline !

@adamsitnik
Copy link
Collaborator

@abmaonline please accept the license #2270 (comment)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.09%. Comparing base (4a49dfa) to head (83b325f).
Report is 26 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2270      +/-   ##
==========================================
- Coverage   64.25%   64.09%   -0.17%     
==========================================
  Files         248      248              
  Lines        8399     8302      -97     
  Branches      590      575      -15     
==========================================
- Hits         5397     5321      -76     
+ Misses       2853     2838      -15     
+ Partials      149      143       -6     
Flag Coverage Δ
SqlServer 30.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abmaonline
Copy link
Contributor Author

@dotnet-policy-service agree

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@adamsitnik adamsitnik merged commit c1ef65d into Xabaril:master Dec 3, 2024
1 check passed
@adamsitnik adamsitnik added this to the 9.0 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants