Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integrated image optimization with next-gen image formats #12

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

wrobelda
Copy link

What does this PR change? What problem does it solve?

This adds responsive image partial, based on the gruvbox's theme, with some additional fixes on my end. Its generates additional image resolutions for both JPEG and WebP and uses those in the figure\img\picture element.

The PR also adapts the markdown image renderer and the figure shortcode to use that partial. It doesn't touch the cover partial, since it already has own code for responsive image, albeit without the WebP generation part. I did not feel confident to adapt its code, considering it is relatively more complex.

Was the change discussed in an issue or in the Discussions before?

Not aware of.

PR Checklist

  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@wrobelda wrobelda changed the title Add responsive image renderer Add integrated image optimization with next-gen image formats and lazy loading May 27, 2024
@wrobelda wrobelda changed the title Add integrated image optimization with next-gen image formats and lazy loading Add integrated image optimization with next-gen image formats May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant