Github Actions uploads built artifacts #83
Conversation
pchickey
force-pushed
the
pch/gh_actions_upload
branch
from
511dd03 to
ed58b06
Compare
pchickey
force-pushed
the
pch/gh_actions_upload
branch
from
c4515c4 to
d75e4a4
Compare
pchickey
changed the title
pchickey
changed the title
deb_from_installation.sh
Outdated
| else | ||
| export VERSION=`./version.sh` | ||
| OUTDIR=$PWD/build |
.github/workflows/main.yml
Outdated
| @@ -40,3 +40,7 @@ jobs: | |||
| - run: sudo make -j4 package | |||
| shell: bash | |||
| name: Build | |||
| - uses: actions/upload-artifact@v1 | |||
| with: | |||
| name: ${{ format( 'packages-{0}.tgz', matrix.os) }} | |||
There was a problem hiding this comment.
Can you explain this line?
What is packages-?
Is there any way to test this? Don't we want to limit this to only uploading for tags?
There was a problem hiding this comment.
I renamed it dist to be more consistent, and added a comment.
The upload appears in the "Actions" tab on GH, and its not actually a release. It just allows us to download the Actions-built contents of dist, untar that into the actual built artifacts, and then upload those to a tag. I gave up on programming that sequence in yml, so we can do that by hand until someone dles.
There was a problem hiding this comment.
Sweet! So we can get a copy of the sdk for each pull request. Nice. Out of interest do you know are disk space limits enforced on this kind of resource?
This changes the build scripts to put the artifacts we use for releases in
dist/, and has Github Actions upload those artifacts to Github.I tried doing some yaml programming to automate putting those artifacts into a release, but I wasn't having a great time of it, but this should make it much easier to produce releases by manually downloading artifacts and then attaching them to a release, rather than build them locally.