Various github action cleanups / improvements #104
Merged
+20
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't build pushes to non-main branches, only build the PR itself. - Remove special windows llvm-nm installation The SDK build process itself builds llvm so we don't need to download it. - Make the `name` the first item in each step. I peronally find this more readable.
pchickey
approved these changes
Feb 21, 2020
|
The windows build is a lot slower.. (good things its broken :) |
kildom
pushed a commit
to kildom/clang-wasi-port
that referenced
this pull request
Jul 14, 2021
* Remove -fno-builtin. -fno-builtin suppresses optimizations such as turning calls to `sqrt` or `fabs` into `f64.sqrt` or `f64.abs` instructions inline. Libc code itself benefits from these optimizations. I originally added this flag because historically it was needed when building libc to avoid the compiler pattern-matching the body of memcpy into a memcpy call, however clang no longer requires this. * Expand the comment about why we use USE_DL_PREFIX in dlmalloc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK build process itself builds llvm so we don't need to download
it.
namethe first item in each step. I peronally findthis more readable.