Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort lists of input files #313

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Sort lists of input files #313

merged 1 commit into from
Aug 9, 2022

Conversation

bmwiedemann
Copy link

Sort lists of input files
for reproducible .a files in spite of non-deterministic
filesystem readdir order

Without this patch, find returned files in filesystem order
and llvm-ar used that order to create .a files.

This PR was done while working on reproducible builds for openSUSE.

for reproducible .a files in spite of non-deterministic
filesystem readdir order

Without this patch, find returned files in filesystem order
and llvm-ar used that order to create .a files.
@sbc100 sbc100 requested a review from sunfishcode August 1, 2022 16:30
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me

@sbc100 sbc100 merged commit 69031b6 into WebAssembly:main Aug 9, 2022
john-sharratt pushed a commit to john-sharratt/wasix-libc that referenced this pull request Mar 5, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
For reproducible .a files in spite of non-deterministic
filesystem readdir order

Without this patch, find returned files in filesystem order
and llvm-ar used that order to create .a files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants