Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update WASI and partially regenerate api.h #282

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

rvolosatovs
Copy link
Contributor

@rvolosatovs rvolosatovs commented Apr 4, 2022

Updated the WASI dependency and partially regenerated api.h using existing tooling.

Most notably this is required for sock_accept support added in WebAssembly/WASI#458

@rvolosatovs rvolosatovs changed the title update WASI and partially regenerate api.h build: update WASI and partially regenerate api.h Apr 4, 2022
@rvolosatovs rvolosatovs marked this pull request as ready for review April 4, 2022 15:47
@rvolosatovs rvolosatovs force-pushed the feat/sock_accept branch 2 times, most recently from 0888ea4 to 0f61f57 Compare April 4, 2022 16:05
@sunfishcode
Copy link
Member

Would you be able to rebase this on main? I expect that will fix the CI failure here.

@rvolosatovs
Copy link
Contributor Author

Would you be able to rebase this on main? I expect that will fix the CI failure here.

Sure! I'll see if I have time tomorrow, otherwise will address it next week

@rvolosatovs
Copy link
Contributor Author

rvolosatovs commented Apr 14, 2022

@sunfishcode done, please take a look

The commit applied cleanly and it seems that there were no significant (potentially breaking) changes in the area

@rvolosatovs
Copy link
Contributor Author

Filed a follow-up #284

@npmccallum
Copy link

@sunfishcode Could this be merged? We'd like to move on to accept support.

@sunfishcode
Copy link
Member

Yes, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants