Update signal macros after upgrade to snapshot1 #144
Merged
+60
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
reviewed
Dec 3, 2019
This should probably have been part of #140 but we don't actually support signals so this doesn't get much testing I imagine. The old names like `__WASI_SIGBUS` no longer exist and the new names look like `__WASI_SIGNAL_BUS`.
|
I don't mind them disappearing completely. I'd still like to land this for correctness though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should probably have been part of #140 but we don't actually
support signals so this doesn't get much testing I imagine.
The old names like
__WASI_SIGBUSno longer exist and the new nameslook like
__WASI_SIGNAL_BUS.