chore: remove deprecated method from project-service #9498
+66
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
gastonfournier
commented
Mar 10, 2025
| ); | ||
|
|
||
| const result = await projectService.getStatusUpdates(project.id); | ||
| expect(result.updates.projectMembersAddedCurrentWindow).toBe(6); // 5 members + 1 owner | ||
| expect(result.updates.projectActivityCurrentWindow).toBe(6); | ||
| expect(result.updates.projectActivityCurrentWindow).toBe(2); |
There was a problem hiding this comment.
@FredrikOseberg @kwasniew this one caught my attention. Instead of adding 5 users in 5 independent operations, we could add all of them in one operation. I'm just curious what we use this projectActivityCurrentWindow for, because if it's intended to count 5 in a bulk update instead of 1, maybe it's not counting as it's supposed to.
gastonfournier
commented
Mar 10, 2025
| @@ -944,7 +934,7 @@ test('should add admin users to the project', async () => { | |||
| await isProjectUser(adminUsers[2].id, project.id, true); | |||
| }); | |||
|
|
|||
| test('add user should fail if user already have access', async () => { | |||
| test('add user do nothing if user already has access', async () => { | |||
There was a problem hiding this comment.
Highlighting this change in behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/bricks-software/unleash-enterprise/pull/137
This method has been deprecated and has an alternative. Migrating to that alternative