Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot open zarr array with "fill_value": null #2063

Closed
rouault opened this issue Aug 9, 2021 · 2 comments · Fixed by #2066
Closed

cannot open zarr array with "fill_value": null #2063

rouault opened this issue Aug 9, 2021 · 2 comments · Fixed by #2066

Comments

@rouault
Copy link
Contributor

rouault commented Aug 9, 2021

netcdf git at 84f0696, Ubuntu 20.04
on the attached zarr dataset byte_fill_value_null.zarr.zip (after unzipping it),

$ ncdump/ncdump "file:///tmp/byte_fill_value_null.zarr#mode=zarr,file"
ncdump/ncdump: file:///tmp/byte_fill_value_null.zarr#mode=zarr,file: NetCDF: NCZarr error

Changing fill_value to a numeric value works around the issue
@DennisHeimbigner
Copy link
Collaborator

DennisHeimbigner commented Aug 9, 2021 •
edited
Loading

Ok, I am testing fixes for:
Issue #2063
Issue #2062
Issue #2061
Issue #2059
Thanks for catching these.

DennisHeimbigner added a commit to DennisHeimbigner/netcdf-c that referenced this issue Aug 9, 2021
@DennisHeimbigner
Fix a number of bugs in the nczarr code.
ec258bf 
re: Issues Unidata#2063, Unidata#2062, Unidata#2061, Unidata#2059

1. Support "fill_value: null" (Unidata#2063).
2. Handle the dtype case "|u1" (Unidata#2062).
3. When writing a pure Zarr format file, some nczarr attributes inadvertently crept in (Unidata#2061).
4. If there is no fill value, then the .zarray fill_value key should have the value null rather than left out (Unidata#2059).

Hat tip: Even Rouault
@DennisHeimbigner DennisHeimbigner mentioned this issue Aug 9, 2021
Merged
@DennisHeimbigner
Copy link
Collaborator

Fixed by PR #2066

@nhlc143796 nhlc143796 mentioned this issue Feb 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a number of bugs in the nczarr code. DennisHeimbigner/netcdf-c
2 participants
@DennisHeimbigner @rouault