Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: echo does not break test execution result #275

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

cmayo
Copy link
Collaborator

@cmayo cmayo commented Jun 27, 2024

📚 Description

This PR is for solving the issue #272

Echo statement with a new line inside a test was breaking the test execution result data and the head pipe on this variable was getting the echoed data and not the test execution result. As the test execution result data will be always at the last line, changing head to tail could resolve this issue.

✅ To-do list

  • I updated the CHANGELOG.md to reflect the new feature or fix
  • I updated the documentation to reflect the changes

@cmayo cmayo force-pushed the fix_echo_breaks_text_execution_results branch from 14509ef to 6b2e101 Compare June 27, 2024 12:35
@Chemaclass Chemaclass added the bug Something isn't working label Jun 27, 2024
Copy link
Member

@Chemaclass Chemaclass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Many thanks! 🙏

@Chemaclass Chemaclass merged commit b03094d into main Jun 27, 2024
7 checks passed
@Chemaclass Chemaclass deleted the fix_echo_breaks_text_execution_results branch June 27, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants