Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DynamicPPL v0.35 #2488

Draft
wants to merge 10 commits into
base: breaking
Choose a base branch
from
Draft

Support for DynamicPPL v0.35 #2488

wants to merge 10 commits into from

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Feb 14, 2025

Work in progress

@penelopeysm
Copy link
Member

penelopeysm commented Feb 20, 2025

I wanted to get CI running, so I committed a Manifest.toml which pointed to the appropriate branch — we can just remove it before merging

Removed

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 35.59322% with 76 lines in your changes missing coverage. Please review.

Project coverage is 44.52%. Comparing base (6088517) to head (2adec09).

Files with missing lines Patch % Lines
src/optimisation/Optimisation.jl 0.00% 28 Missing ⚠️
ext/TuringOptimExt.jl 0.00% 15 Missing ⚠️
src/mcmc/sghmc.jl 0.00% 11 Missing ⚠️
ext/TuringDynamicHMCExt.jl 0.00% 7 Missing ⚠️
src/mcmc/emcee.jl 0.00% 4 Missing ⚠️
src/mcmc/is.jl 0.00% 3 Missing ⚠️
src/mcmc/ess.jl 84.61% 2 Missing ⚠️
src/mcmc/hmc.jl 87.50% 2 Missing ⚠️
src/mcmc/mh.jl 60.00% 2 Missing ⚠️
src/mcmc/particle_mcmc.jl 50.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6088517) and HEAD (2adec09). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (6088517) HEAD (2adec09)
49 21
Additional details and impacted files
@@              Coverage Diff              @@
##           breaking    #2488       +/-   ##
=============================================
- Coverage     85.15%   44.52%   -40.63%     
=============================================
  Files            21       21               
  Lines          1522     1424       -98     
=============================================
- Hits           1296      634      -662     
- Misses          226      790      +564     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Remove LogDensityProblemsAD, part 1

* update Optimisation code to not use LogDensityProblemsAD

* Fix field name change

* Don't put chunksize=0

* Remove LogDensityProblemsAD dep

* Improve OptimLogDensity docstring

* Remove unneeded model argument to _optimize

* Fix more tests

* Remove essential/ad from the list of CI groups

* Fix HMC function
* Remove LogDensityProblemsAD, part 1

* update Optimisation code to not use LogDensityProblemsAD

* Fix field name change

* Don't put chunksize=0

* Remove LogDensityProblemsAD dep

* Improve OptimLogDensity docstring

* Remove unneeded model argument to _optimize

* Fix more tests

* Remove essential/ad from the list of CI groups

* Fix HMC function

* More test fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants