Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated test script to pass string to mocha #1

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

allouis
Copy link
Contributor

@allouis allouis commented Oct 4, 2018

no-issue

This is because the shell will try to expand the glob if it's not
wrapped in strings, which can give different outcomes depending on the
globbing supporting by the shell. Passing a string will allow mocha to
sort out globbing which is more predictable.

Related issue is here: mochajs/mocha#1828

@allouis allouis requested a review from ErisDS October 4, 2018 09:59
no-issue

This is because the shell will try to expand the glob if it's not
wrapped in strings, which can give different outcomes depending on the
globbing supporting by the shell. Passing a string will allow mocha to
sort out globbing which is more predictable.

Related issue is here: mochajs/mocha#1828
@ErisDS ErisDS merged commit a45c210 into TryGhost:master Oct 4, 2018
@allouis allouis deleted the update-test-generator branch October 4, 2018 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants