Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish 5.0.1 #1386

Closed
awjreynolds opened this issue Sep 24, 2020 · 11 comments
Closed

Publish 5.0.1 #1386

awjreynolds opened this issue Sep 24, 2020 · 11 comments

Comments

@awjreynolds
Copy link

It appears you've updated and finished 5.0.1 but have not published it to npm etc.
@awjreynolds
Copy link
Author

awjreynolds commented Sep 25, 2020 •
edited
Loading

@kewde I note you released 5.0.1 16 days ago. Can this be published to npm so that we can pick up on these changes.

SNYK has identified an issue with 5.0.0 which is fixed by 5.0.1

Note that the repo readme reflects the changes in 5.0.1 not those that are in 5.0.0. Hence the discrepancy we are getting identifying sqlite3 as 3.31.1 (https://nvd.nist.gov/vuln/detail/CVE-2020-11656) and not 3.32.2 as declared in the readme.

Hugely appreciate your work on this.

@ducqhl
Copy link

ducqhl commented Oct 28, 2020

Any progress on this?

@alexrecuenco
Copy link

We are wondering if there is any update on this

@hverlin
Copy link

hverlin commented Nov 20, 2020 •
edited
Loading

Hi, do you have an update on this? Is there anything we can do to help?
We can use the commit hash for now but there is no binary available (git://github.com/mapbox/node-sqlite3#e87dfa474dd89e20fd9361e7cf845aa88ae2ec1b)

kevinansfield added a commit to kevinansfield/Ghost that referenced this issue Nov 26, 2020
@kevinansfield
Fixed sqlite3 errors when email analytics jobs run
981a8b0 
no issue

- the 4.2.0 version of `sqlite3` that we're using is not compatible with `worker_threads`
- 5.0.0 should add support this but there are other errors
- 5.0.1 is released but not published (TryGhost/node-sqlite3#1386)
@kevinansfield kevinansfield mentioned this issue Nov 26, 2020
Merged
kevinansfield added a commit to TryGhost/Ghost that referenced this issue Nov 26, 2020
@kevinansfield
Fixed sqlite3 errors when email analytics jobs run (#12431)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a29ac26 
no issue

- the 4.2.0 version of `sqlite3` that we're using is not compatible with `worker_threads`
- 5.0.0 should add support this but there are other errors
- 5.0.1 is released but not published (TryGhost/node-sqlite3#1386)
@naz
Copy link

naz commented Nov 29, 2020

@kewde adding to the rest of comments above ➕ Would love to help 5.0.1 npm publish happen as well.

P.S. Big thanks for all the work you've put into this project 🖤

@Jolg42
Copy link

Jolg42 commented Dec 2, 2020

Same here 👍 (Posting here to be sure to get a notification)

@trevyn
Copy link

trevyn commented Dec 18, 2020

Looks like this post might add some color:

https://kewde.github.io/sqlite

Sounds like kewde wants someone trustworthy with experience being a long-term open-source maintainer and who relies on node-sqlite3 for their business to step up and make a long-term commitment to helping maintain. Any takers?

@ErisDS ErisDS mentioned this issue Jan 8, 2021
Closed
@naz
Copy link

naz commented Jan 11, 2021

5.0.1 has been published on npm 🎉

@naz
Copy link

naz commented Jan 11, 2021

@awjreynolds think this issue can be closed now?

@awjreynolds
Copy link
Author

Fantastic!

@ducqhl
Copy link

ducqhl commented Jan 14, 2021

thank you!

naz added a commit to TryGhost/Ghost that referenced this issue Jun 29, 2021
@naz
Added protective code to update-check job

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
7e9c182 
refs #13091

- When the job is run under Node v14 with SQLite DB the parentPort is `null` in some of the environments. The guarding code protects from the job crashing in such situation.
- The most probable cause is running btrheds with `BTHREADS_BACKEND = 'child_process';` configuration for SQLite. Should be fixed once TryGhost/node-sqlite3#1386 is properly resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@trevyn @naz @Jolg42 @awjreynolds @hverlin @ducqhl @alexrecuenco