Remove futures crates as depdencies #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a single function and struct: either. This new Future helper poll two futures and returns the result of the future that completes first.
A convenience method for Streams to get the next item as a Future.
Pulled in a lot of crates for very little benefit.
Only used a single type from it, but it pulled in many dependencies.
Remove the futures-core as dependency.
Thomasdezeeuw
force-pushed
the
rm_futures-core
branch
from
7ce001f to
7a9cdfa
Compare
This was referenced Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all future-* crates as dependencies.
Reduce the number of crates to build from 86 to 63 (when testing). Also reduces the
cargo checkfrom 26.58s to 19.19s.Includes #367.
Includes #368.