-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #10
Develop #10
Conversation
Feature/picker
Feature/redux with header
Create events UI (under construction)
Create profile and settings temporary UI
…organize Feature/code clean up and reorganize
Feature/icons
Add users mock data and connect
Organize mock data, create interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a good idea to extract styles and inline functions outside the MatchHeader component to prevent unnecessary re-renders. This improves performance by ensuring that these objects are not recreated on every render.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean extract color codes to a separate file? And what inline functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was tripping when I said inline functions 😅. However, the inline boxShadow object is still being recreated on every render, which could lead to unnecessary re-renders. It would be better to move this logic outside the component into a separate function (getBoxShadow) above the const MatchHeader to ensure better performance and maintainability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the store configuration and state types are properly defined. Also add reducers to the reducer
object and define the state types for better type safety.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define types for component props, even if there are no props, use FC (Function Component) type for better type safety.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to extract styles and inline functions outside the component to prevent unnecessary re-renders. This improves performance by ensuring that these objects are not recreated on every render.
This pull request introduces several key features and improvements to the project, focusing on setting up state management, and UI components, and optimizing the code structure.
Key Changes: