Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #10

Merged
merged 33 commits into from
Mar 7, 2025
Merged

Develop #10

merged 33 commits into from
Mar 7, 2025

Conversation

TheCoderSingh
Copy link
Owner

This pull request introduces several key features and improvements to the project, focusing on setting up state management, and UI components, and optimizing the code structure.

Key Changes:

  • Redux Setup: Integrated Redux Toolkit for state management.
  • Picker Component: Implemented a reusable picker component for UI interactions.
  • Header Improvements: Fixed header shadow issues and created a features/matchHeader component.
  • UI Enhancements:
    • Built a hardcoded homepage UI and adjusted header height.
    • Created a dedicated LinkBar and RoundedButton component for better reusability.
    • Designed the matches page UI.
    • Developed an initial version of the events UI.
    • Created temporary UI for profile and settings screens.
  • Code Optimization & Cleanup:
    • Reorganized the codebase for better maintainability.
    • Standardized shadow styles and fixed casing/path issues.
    • Added colors to the Tailwind configuration.
  • Assets & Icons:
    • Switched to a new icon set and added support for .svg files.
    • Removed unused assets (e.g., construction.png).
  • Mock Data Integration:
    • Added mock user data and connected it to the frontend.
    • Organized mock data and introduced an interface for structured data handling.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Feature/picker

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Feature/redux with header

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Homepage

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Create events UI (under construction)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Create profile and settings temporary UI

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…organize

Feature/code clean up and reorganize

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Feature/icons

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Add users mock data and connect

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Organize mock data, create interface
TheCoderSingh and others added 4 commits February 21, 2025 17:45

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Add JSdocs and update readme
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a good idea to extract styles and inline functions outside the MatchHeader component to prevent unnecessary re-renders. This improves performance by ensuring that these objects are not recreated on every render.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean extract color codes to a separate file? And what inline functions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was tripping when I said inline functions 😅. However, the inline boxShadow object is still being recreated on every render, which could lead to unnecessary re-renders. It would be better to move this logic outside the component into a separate function (getBoxShadow) above the const MatchHeader to ensure better performance and maintainability.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the store configuration and state types are properly defined. Also add reducers to the reducer object and define the state types for better type safety.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define types for component props, even if there are no props, use FC (Function Component) type for better type safety.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to extract styles and inline functions outside the component to prevent unnecessary re-renders. This improves performance by ensuring that these objects are not recreated on every render.

@TheCoderSingh TheCoderSingh merged commit bf8a15e into main Mar 7, 2025
@TheCoderSingh TheCoderSingh deleted the develop branch March 7, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants