perf(core): 去除加载插件对getPackageArchiveInfo的依赖 #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shifujun
commented
Dec 30, 2021
...der/src/main/kotlin/com/tencent/shadow/core/loader/delegates/ShadowNativeActivityDelegate.kt
Outdated
Show resolved
Hide resolved
shifujun
commented
Dec 30, 2021
.../sdk/core/loader/src/main/kotlin/com/tencent/shadow/core/loader/managers/ComponentManager.kt
Outdated
Show resolved
Hide resolved
shifujun
commented
Dec 30, 2021
...arser/src/test/kotlin/com/tencent/shadow/core/manifest_parser/PluginManifestGeneratorTest.kt
Show resolved
Hide resolved
shifujun
commented
Dec 30, 2021
...st-parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/PluginManifestGenerator.kt
Show resolved
Hide resolved
shifujun
changed the title
通过PluginClassLoader新增方法loadPluginManifest可加载该类。 Tencent#696
由于PackageManager.getPackageArchiveInfo方法在解析较大的Manifest时速度很慢， 而且加载插件过程中只依赖很少量的字段，如className，theme等，所以在主路径不再依赖它， 而是依赖编译期生成好的PluginManifest类。 另一原因是getPackageArchiveInfo的返回类型没有公开API告诉我们Receiver的action字段。 在插件代码主动通过PackageManager获取信息时，再依赖getPackageArchiveInfo方法 获取MetaData等插件框架本身不需要的信息。 close Tencent#696
shifujun
force-pushed
the
manifest-parser
branch
from
c937b3f to
73974f6
Compare
shifujun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
由于PackageManager.getPackageArchiveInfo方法在解析较大的Manifest时速度很慢，
而且加载插件过程中只依赖很少量的字段，如className，theme等，所以在主路径不再依赖它，
而是依赖编译期生成好的PluginManifest类。
另一原因是getPackageArchiveInfo的返回类型没有公开API告诉我们Receiver的action字段。
在插件代码主动通过PackageManager获取信息时，再依赖getPackageArchiveInfo方法
获取MetaData等插件框架本身不需要的信息。
close #696