Skip to content

deprecate usage of ShareDbMongo as a function #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dcharbonnier
Copy link

Anticipate the es6 class

@coveralls
Copy link

coveralls commented Jul 13, 2018

Pull Request Test Coverage Report for Build 14

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 89.814%

Files with Coverage Reduction New Missed Lines %
index.js 3 89.81%
Totals Coverage Status
Change from base Build 12: 0.1%
Covered Lines: 650
Relevant Lines: 700

💛 - Coveralls

@gkubisa gkubisa self-requested a review July 13, 2018 14:51
Copy link

@gkubisa gkubisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@curran
Copy link

curran commented Jul 14, 2018

Looks great! Will require a major version bump though, to respect semver.

Related #3

@gkubisa
Copy link

gkubisa commented Jul 15, 2018

This is just a console.warn, so a patch version is fine. We'll need to bump the major version when we actually start throwing errors.

@curran
Copy link

curran commented Jul 16, 2018

Good call!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants