Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let some apis in PlayersAPI return TaloPlayer directly. #84

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Let some apis in PlayersAPI return TaloPlayer directly. #84

merged 1 commit into from
Feb 25, 2025

Conversation

Daylily-Zeleen
Copy link
Contributor

A part of #70 .

And let update() try to update current player instead of creating a new instance.

@Daylily-Zeleen
Let some apis in PlayersAPI return TaloPlayer directly, and let `up…
ebaf251 
…date()` try to update current player instead of creating a new instance.
tudddorrr
tudddorrr approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@tudddorrr tudddorrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great change, thanks!

@tudddorrr tudddorrr added the enhancement New feature or request label Feb 25, 2025
@tudddorrr tudddorrr merged commit 2383780 into TaloDev:develop Feb 25, 2025
@Daylily-Zeleen Daylily-Zeleen deleted the return_talo_player branch February 28, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tudddorrr tudddorrr tudddorrr approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Daylily-Zeleen @tudddorrr