Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: align with standard-GEM template v0.5 #6

Merged
merged 1 commit into from
Jan 14, 2021
Merged

style: align with standard-GEM template v0.5 #6

merged 1 commit into from
Jan 14, 2021

Conversation

haowang-bioinfo
Copy link
Member

@haowang-bioinfo haowang-bioinfo commented Dec 21, 2020 •
edited
Loading

Main improvements in this PR:

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected devel as a target branch

mihai-sysbio
mihai-sysbio requested changes Jan 7, 2021
View reviewed changes
Copy link
Member

@mihai-sysbio mihai-sysbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice that you went through this! I'm requesting a small change, to revert the change of the standard regarding the branch naming convention.

@mihai-sysbio mihai-sysbio changed the base branch from devel to develop January 11, 2021 10:46
@haowang-bioinfo haowang-bioinfo merged commit d1a3c69 into develop Jan 14, 2021
@haowang-bioinfo haowang-bioinfo deleted the style/standardGEM branch January 14, 2021 18:30
@haowang-bioinfo haowang-bioinfo mentioned this pull request Jan 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihai-sysbio mihai-sysbio mihai-sysbio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haowang-bioinfo @mihai-sysbio