Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: only annotate model before SBML export #18

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

JonathanRob
Copy link
Collaborator

Main improvements in this PR:

Many of the model annotation fields added to the model by the annotateGEM function are non-standard and therefore can cause problems with many functions (see Issue #16). However, the function is helpful for adding the annotation information into the SBML file.

This PR re-orders the final steps of the masterScriptMouseGEM.m function to add the annotation information to the model after the .mat and .yml formats have been written, but before writing the SBML model format.

Note: this change should also be made in the other Animal GEM repos.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch

Copy link
Member

@haowang-bioinfo haowang-bioinfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree to implement this change to the other Animal GEMs

@JonathanRob
Copy link
Collaborator Author

@haowang-bioinfo after merging the changes into develop for each of the Animal-GEMs, should I go ahead and merge develop into main, re-run the master script, and commit the updated models to main?

Also, I see that the version field of these models is empty. Should I leave it empty, or update it to the next version (I suggest this is a patch, so +0.0.1 to current version)? I can then try to make a release for each, unless you want to do that.

@haowang-bioinfo
Copy link
Member

@haowang-bioinfo after merging the changes into develop for each of the Animal-GEMs, should I go ahead and merge develop into main, re-run the master script, and commit the updated models to main?

yes, go ahead - check the previous commits as references.

Also, I see that the version field of these models is empty. Should I leave it empty, or update it to the next version (I suggest this is a patch, so +0.0.1 to current version)? I can then try to make a release for each, unless you want to do that.

patch is good

@JonathanRob JonathanRob mentioned this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants