Fix typo in address parameter helper #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adammathys
approved these changes
Mar 15, 2021
jarednorman
requested changes
Mar 16, 2021
Noah-Silvera
approved these changes
Mar 17, 2021
This change adds a failing spec which exposes a typo in our API params helper method. In the next change we'll fix the issue and un-pend the spec.
This change fixes a typo in the params helper for addresses without a `state` association. This was a previously untested behaviour so we never caught this. This change also marks the failing test as no longer pending.
forkata
force-pushed
the
forkata/fix-typo
branch
from
124bdbc to
b1b67da
Compare
Noah-Silvera
requested changes
Mar 18, 2021
This links to the PR where we fixed the issue from the changelog file, so we can know what is in the next release of the gem.
forkata
force-pushed
the
forkata/fix-typo
branch
from
b1b67da to
3b47180
Compare
jarednorman
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Fixes a typo in the helper method which transforms a
Spree::Addressinto the payload parameters we send to TaxJar.How do you manually test these changes? (if applicable)
stateassociation, but with astate_nameinstead.state_namefield should be serialized and sent to Tax Jar.Merge Checklist
Update the changelog(I am not sure if this needs to be done for this change?)