Add OPAProperties to structure properties

[ali-jalaal]

Implements #21

[anderseknert]

Thank you! Looks like a solid imrovement to me. This is backwards compatible, right? Anything we need to the docs, or update? Looks like some tests are failing, so that'd be good to look into.

[ali-jalaal]

Hi @anderseknert, thanks for your review.

This is backwards compatible, right?

Yes, I suppose these changes are backward compatible since public constructors/methods of OPAAuthorizationManager are kept as before and behavior should be the same.

Anything we need to the docs, or update?

I'd suggest that we can update the docs after implementing #22 since after that we could use the features of auto-configuration and configuration-properties.

Looks like some tests are failing

The new tests were passing, however the old tests were failing. By enabling more logs, it seems OPA v1 + nginx have some problems and OPAClient does not return any response (exception: java.io.IOException: HTTP/1.1 header parser received no bytes). In the 3rd commit, I reverted OPA docker image to the 0.70.0 version and all tests were passed.

[anderseknert]

Sorry, forgot to check back here! Just had a question on your change just now, but with that out of the way we can have this merged.

[anderseknert]

Thanks a lot! 👌

[ali-jalaal]

Related to the failed tests with the latest OPA version, I found out here that passing --addr=0.0.0.0:8181 is necessary in v1. However in OPA docs it's mentioned that --addr default value is localhost:8181. It might be a good idea to update this doc to mention this change.

[anderseknert]

Docker can't map a port on the localhost interface? I thought that was just some docker compose thing.

[ali-jalaal]

Docker can't map a port on the localhost interface? I thought that was just some docker compose thing.

It seems by default in OPA v1.0+ server is exposed on localhost:8181 inside the container, which is not accessible from the host machine (at least with the default Docker's network config). I created this issue for following up: open-policy-agent/opa#7360

[anderseknert]

Excellent 👍