Skip to content

base64 encode nonce #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 26, 2023
Merged

base64 encode nonce #91

merged 7 commits into from
Jan 26, 2023

Conversation

alcalawil
Copy link
Contributor

@alcalawil alcalawil commented Jan 12, 2023 •
edited
Loading

Steps to test:

  1. run api and sdk on branch fix/wil/base64-encode-nonce
  2. run the iframe on develop
  3. Get a nonce from Insomnia
  4. sign the nonce in sing_test.go
  5. paste the signature in insomnia. You should be able to create an user.
  6. Open the Iframe and Authorize the same user
  7. Make sure your wallet shows the correct message:

image

8. the user is successfully authorized

@alcalawil alcalawil changed the title encode and decode nonce base64 encode nonce Jan 12, 2023
@alcalawil alcalawil closed this Jan 26, 2023
@alcalawil alcalawil reopened this Jan 26, 2023
@alcalawil alcalawil marked this pull request as ready for review January 26, 2023 01:39
saito-sv
saito-sv reviewed Jan 26, 2023
View reviewed changes
saito-sv
saito-sv previously approved these changes Jan 26, 2023
View reviewed changes
Copy link

@saito-sv saito-sv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ocasta181
ocasta181 previously approved these changes Jan 26, 2023
View reviewed changes
auroter
auroter reviewed Jan 26, 2023
View reviewed changes
auroter
auroter reviewed Jan 26, 2023
View reviewed changes
auroter
auroter reviewed Jan 26, 2023
View reviewed changes
auroter
auroter reviewed Jan 26, 2023
View reviewed changes
@alcalawil alcalawil merged commit 7633c73 into develop Jan 26, 2023
@alcalawil alcalawil deleted the fix/wil/base64-encode-nonce branch January 26, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocasta181 ocasta181 ocasta181 approved these changes

@auroter auroter auroter approved these changes

@saito-sv saito-sv saito-sv left review comments

@frostbournesb frostbournesb Awaiting requested review from frostbournesb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alcalawil @ocasta181 @auroter @saito-sv