Task/sean/str 249 #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 9, 2023 13:03
… with that being signed in addition to the nonce suffix
auroter
requested review from
ocasta181,
saito-sv,
alcalawil and
frostbournesb
ocasta181
previously approved these changes
Jan 10, 2023
frostbournesb
approved these changes
Jan 10, 2023
alcalawil
approved these changes
Jan 10, 2023
|
Looks great!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test:
Docker Up
Test the API via the iframe-app by generating an API key, validating it, and providing it in the iframe-app ENV
Visit http://localhost:5173/
Try verifying your wallet
You should see this:
Signing the message should take you to the Quote, and the transaction should be able to complete as expected.