Skip to content

webhooks #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 28, 2023
Merged

webhooks #241

merged 6 commits into from
Jul 28, 2023

Conversation

saito-sv
Copy link

@saito-sv saito-sv commented Jul 27, 2023 •
edited
Loading

Tests

  • Run the tests within the service by doing go test -run TestHandle ./pkg/service/ -v and make sure they pass.
  • Run the middleware tests by doing go test ./api/middleware/ -v and make sure they pass.

frostbournesb
frostbournesb previously approved these changes Jul 27, 2023
View reviewed changes
@saito-sv saito-sv requested a review from frostbournesb July 27, 2023 17:16
auroter
auroter approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@auroter auroter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both tests passed, looks good.
Uploading image.png…

@saito-sv saito-sv merged commit 11f10c4 into develop Jul 28, 2023
@saito-sv saito-sv deleted the task/marlon/STR-682 branch July 28, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auroter auroter auroter approved these changes

@frostbournesb frostbournesb frostbournesb approved these changes

@ocasta181 ocasta181 Awaiting requested review from ocasta181

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saito-sv @auroter @frostbournesb