Skip to content

Add KYC Service and enable getting user's persona accountId #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 28, 2023
Merged

Add KYC Service and enable getting user's persona accountId #239

merged 12 commits into from
Jul 28, 2023

Conversation

ocasta181
Copy link
Contributor

@ocasta181 ocasta181 commented Jul 26, 2023 •
edited
Loading

STR-679

Changes:

  • Add an endpoint to /users/ that returns the user's persona accountId. It either returns a previously existing persona accountId or creates a new one and returns that.
  • Add KYC service for identifying if the user meets the KYC level needed for a transaction

To test:

  • Use Create Identity Table migrations#18
  • Create a user and hit the /users/persona-account-id endpoint. Confirm a new persona account has been created in the Persona dashboard.
  • Run the unit test TestMeetsRequirements() in kyc_tests.go

@ocasta181 ocasta181 changed the title Enable getting user's persona accountId Add KYC Service and enable getting user's persona accountId Jul 26, 2023
saito-sv
saito-sv reviewed Jul 26, 2023
View reviewed changes
@ocasta181 ocasta181 marked this pull request as ready for review July 27, 2023 06:10
auroter
auroter reviewed Jul 27, 2023
View reviewed changes
auroter
auroter previously approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@auroter auroter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@frostbournesb frostbournesb self-requested a review July 27, 2023 23:08
frostbournesb
frostbournesb previously approved these changes Jul 27, 2023
View reviewed changes
saito-sv
saito-sv previously approved these changes Jul 27, 2023
View reviewed changes
@ocasta181 ocasta181 dismissed stale reviews from saito-sv and frostbournesb via 839065b July 28, 2023 20:05
@ocasta181 ocasta181 merged commit 09a2ebe into develop Jul 28, 2023
@ocasta181 ocasta181 deleted the task/andrin/str-679 branch July 28, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saito-sv saito-sv saito-sv approved these changes

@frostbournesb frostbournesb frostbournesb approved these changes

@auroter auroter Awaiting requested review from auroter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ocasta181 @auroter @saito-sv @frostbournesb