-
Notifications
You must be signed in to change notification settings - Fork 0
Task/sean/str 698 #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Task/sean/str 698 #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…20 transfer events
…ution of multiple calls, added calls for NFT and Token Forwarding (not complete yet)
…cko always appeared to be down, fixed an issue with updating the timestamp of a cached token value even when failing to retrieve a new value
…ransact return body) and unit21
…d a bug where finding 0 tokens to forward for ERC721 or ERC20 reported an error, fixed a bug where forwards failed because they were using safeTransferFrom without an approve, added true max gas caching for each transaction request, fixed a bug where forwarding would be attempted when there was nothing to forward, added true gas summing including forwarding
…s during Cost estimation if network oracle name is set to "internal" in the db. Also use this value when generating the real evm transaction request.
ocasta181
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
saito-sv
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an internal Gas Rate calculator for networks that Owlracle does not support (such as DFK Subnet). This will eventually be used in conjunction with a gas analysis service that determines the boost and tip % for a given network at the current moment in time.
To test: