Skip to content

Task/andrin/str 354 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 13, 2023
Merged

Task/andrin/str 354 #115

merged 5 commits into from
Feb 13, 2023

Conversation

ocasta181
Copy link
Contributor

@ocasta181 ocasta181 commented Feb 12, 2023 •
edited
Loading

  1. Confirm that you can successfully execute transactions.
  2. Confirm that when executing transactions, Unit21 receives new instruments and transactions, and that the instruments have the proper type: "Credit Card", "Debit Card", or "Crypto Wallet".
  3. Confirm that if you pass a failing card, the transaction is prevented from occurring, and that a new instrument is created.

@ocasta181 ocasta181 marked this pull request as ready for review February 12, 2023 20:18
saito-sv
saito-sv previously approved these changes Feb 13, 2023
View reviewed changes
Copy link

@saito-sv saito-sv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

auroter
auroter reviewed Feb 13, 2023
View reviewed changes
@alcalawil
Copy link
Contributor

image

@auroter auroter self-requested a review February 13, 2023 19:32
auroter
auroter approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@auroter auroter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working now!

@ocasta181 ocasta181 merged commit 12b1efb into develop Feb 13, 2023
@ocasta181 ocasta181 deleted the task/andrin/str-354 branch February 13, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auroter auroter auroter approved these changes

@alcalawil alcalawil alcalawil approved these changes

@saito-sv saito-sv saito-sv left review comments

@frostbournesb frostbournesb Awaiting requested review from frostbournesb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ocasta181 @alcalawil @auroter @saito-sv