Skip to content

Refactor Transaction Execute #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 12, 2023
Merged

Refactor Transaction Execute #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
df4214f
first pass at refactoring executor
ocasta181 Feb 9, 2023
0dff507
abstract card payment steps
ocasta181 Feb 10, 2023
8d5e951
more cleanup
ocasta181 Feb 10, 2023
98f293c
s to p
ocasta181 Feb 10, 2023
3228e38
cleaned up errors
ocasta181 Feb 10, 2023
fddd864
fixing bugs
ocasta181 Feb 10, 2023
1d53069
working as expected
ocasta181 Feb 10, 2023
ceba54f
remove sign_test changes
ocasta181 Feb 10, 2023
c407b40
revert card changes
ocasta181 Feb 10, 2023
2842e9f
Added more comments to postProcess and moved it closer to the top of …
Feb 10, 2023
14db6eb
Update pkg/service/transaction.go
Feb 10, 2023
71c4589
close executor earlier
Feb 10, 2023
b9d9f23
clean up executor calls
ocasta181 Feb 10, 2023
e8b8e0e
Merge branch 'task/andrin/str-416' of github.com:String-xyz/string-ap…
ocasta181 Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/service/checkout.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func AuthorizeCharge(amount float64, userWallet string, tokenId string) (auth Au
Type: checkoutCommon.Card,
Number: "4242424242424242", // Success
// Number: "4273149019799094", // succeed authorize, fail capture
// Number: "4544249167673670", // Declined - Insufficient funds
// Number: "4544249167673670", // Declined - Insufficient funds
// Number: "5148447461737269", // Invalid transaction
ExpiryMonth: 2,
ExpiryYear: 2024,
Expand Down
Loading