Skip to content

delete docker compose (we moved it to infra/local) and update readme … #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

auroter
Copy link
Contributor

@auroter auroter commented Jan 27, 2023

Wilfredo and I pair coded to move the docker-compose into infra, so that we can simultaneously debug the platform-admin-api and the main api at the same time if needed. The readme has been updated to include the commands required in order to run and debug in this manner.

See infra PR:
String-xyz/infra#18
The PR for str-373 is still in progress but includes these updates.

To test: (Instructions are now also included in readme.md in the main API)

  1. Ensure you have the platform-admin-api repo
  2. On platform-admin-api repo, checkout task/sean/str-373
  3. Make sure to copy .env.example into your .env. The .env.example was updated to reflect the correct postgres and redis values.
  4. Ensure you have the infra repo
  5. On the infra repo, checkout task/sean/docker
  6. Ensure you have the string-api repo
  7. On the string-api repo, checkout task/sean/docker-readme

You can run docker compose from any repo now, and it will compose string-api, platform-admin-api, postgres and redis.

Some initial sanitation: [do this from the infra repo]

  1. cd local
  2. docker compose down
  3. docker system prune (/y)
  4. docker volume prune (/y)

And then this can be run from any repo:
4) docker compose -f ../infra/local/docker-compose.yml up

You should automatically get console output from whichever repo you run the previous command from. To get live console output from the other repo:

  1. docker ps to list the docker container names
  2. docker logs [docker container name] -f
  3. for example, docker logs platform-admin-api -f or docker logs string-api -f from a terminal in the repo you did not run the docker compose from

ocasta181
ocasta181 previously approved these changes Jan 28, 2023
alcalawil
alcalawil previously approved these changes Jan 28, 2023
@auroter auroter dismissed stale reviews from alcalawil and ocasta181 via c55bf9d January 30, 2023 18:56
@auroter auroter requested a review from alcalawil January 30, 2023 19:32
@auroter auroter merged commit a8a4f49 into develop Jan 30, 2023
@auroter auroter deleted the task/sean/docker-readme branch January 30, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants