Feat/automated backups #2142
Merged
Feat/automated backups #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattDHill
force-pushed
the
feat/automated-backups
branch
from
d90dcf2 to
e85ac41
Compare
waterplea
reviewed
Feb 16, 2023
frontend/projects/shared/src/pipes/unit-conversion/unit-conversion.pipe.ts
Outdated
Show resolved
Hide resolved
| <ion-item color="warning" class="ion-margin-bottom"> | ||
| <ion-icon slot="start" name="warning-outline"></ion-icon> | ||
| <ion-label> | ||
| <h2 style="font-weight: bold">You are using unencrypted http</h2> |
There was a problem hiding this comment.
I don't like inline styles because we already have a dedicated styles file, since you moved it to a separate component, would be nice to also move these 2 inline styles in a class in SCSS file.
frontend/projects/ui/src/app/components/insecure-warning/insecure-warning.component.ts
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| @Component({ |
There was a problem hiding this comment.
Nitpicking tip: It's easier to maintain when there's a single component per file.
frontend/projects/ui/src/app/pages/backups-routes/modals/target-select/target-select.page.ts
Outdated
Show resolved
Hide resolved
frontend/projects/ui/src/app/pages/backups-routes/pages/backup-targets/backup-targets.page.ts
Outdated
Show resolved
Hide resolved
frontend/projects/ui/src/app/pages/backups-routes/pages/backup-targets/backup-targets.page.ts
Outdated
Show resolved
Hide resolved
| try { | ||
| this.targets = await this.api.getBackupTargets({}) | ||
| } catch (e: any) { | ||
| this.errToast.present(e) |
There was a problem hiding this comment.
I don't remember for sure, maybe we discussed that already, but there's quite a lot of places like that. Maybe some universal error handler through ErrorHandler could be helpful?
https://angular.io/api/core/ErrorHandler
| @Pipe({ | ||
| name: 'platformInfo', | ||
| }) | ||
| export class PlatformInfoPipe implements PipeTransform { |
There was a problem hiding this comment.
Maybe this could be helpful?
https://material.angular.io/cdk/platform/api
| </ion-row> | ||
| <!-- loading --> | ||
| <ng-container *ngIf="loading$ | async; else loaded"> | ||
| <ion-row class="ion-align-items-center grid-row-border"> |
There was a problem hiding this comment.
Looks like we got this setup quite often, maybe we should make a component loading-row [number]="x" to show x amount of ion-row with a skeleton?
MattDHill
force-pushed
the
feat/automated-backups
branch
from
fecfb58 to
4a5f8b3
Compare
MattDHill
force-pushed
the
feat/automated-backups
branch
from
4f1ee0e to
2a2df6c
Compare
MattDHill
force-pushed
the
feat/automated-backups
branch
from
2a2df6c to
1e122b0
Compare
MattDHill
force-pushed
the
feat/automated-backups
branch
2 times, most recently
from
47c2dbb to
df70682
Compare
MattDHill
force-pushed
the
feat/automated-backups
branch
from
df70682 to
9b1b559
Compare
dr-bonez
force-pushed
the
integration/refactors
branch
from
9f4dc17 to
4d1d941
Compare
MattDHill
force-pushed
the
feat/automated-backups
branch
6 times, most recently
from
f4bf31c to
e37b25c
Compare
MattDHill
force-pushed
the
feat/automated-backups
branch
from
1a8f87e to
aff395f
Compare
MattDHill
force-pushed
the
integration/refactors
branch
from
29a16a8 to
a5bf27a
Compare
MattDHill
force-pushed
the
feat/automated-backups
branch
from
aff395f to
970f3d0
Compare
MattDHill
force-pushed
the
feat/automated-backups
branch
from
970f3d0 to
325af00
Compare
MattDHill
force-pushed
the
integration/refactors
branch
from
64b8b3d to
bc42781
Compare
MattDHill
force-pushed
the
feat/automated-backups
branch
from
325af00 to
18c3211
Compare
MattDHill
force-pushed
the
feat/automated-backups
branch
from
18c3211 to
ae38c57
Compare
MattDHill
added a commit
that referenced
this pull request
May 16, 2023
* initial restructuring * very cool * new structure in place * delete unnecessary T * down the rabbit hole * getting better * dont like it * nice * very nice * sessions select all * nice * backup runs * fix targets and more * small improvements * mostly working * address PR comments * fix error * delete issue with merge * fix checkboxes and add API for deleting backup runs * better styling for checkboxes * small button in ssh kpage too * complete multiple UI launcher * fix actions * present error toast too * fix target forms
MattDHill
added a commit
that referenced
this pull request
May 17, 2023
* initial restructuring * very cool * new structure in place * delete unnecessary T * down the rabbit hole * getting better * dont like it * nice * very nice * sessions select all * nice * backup runs * fix targets and more * small improvements * mostly working * address PR comments * fix error * delete issue with merge * fix checkboxes and add API for deleting backup runs * better styling for checkboxes * small button in ssh kpage too * complete multiple UI launcher * fix actions * present error toast too * fix target forms
MattDHill
added a commit
that referenced
this pull request
May 18, 2023
* initial restructuring * very cool * new structure in place * delete unnecessary T * down the rabbit hole * getting better * dont like it * nice * very nice * sessions select all * nice * backup runs * fix targets and more * small improvements * mostly working * address PR comments * fix error * delete issue with merge * fix checkboxes and add API for deleting backup runs * better styling for checkboxes * small button in ssh kpage too * complete multiple UI launcher * fix actions * present error toast too * fix target forms
MattDHill
added a commit
that referenced
this pull request
May 22, 2023
* initial restructuring * very cool * new structure in place * delete unnecessary T * down the rabbit hole * getting better * dont like it * nice * very nice * sessions select all * nice * backup runs * fix targets and more * small improvements * mostly working * address PR comments * fix error * delete issue with merge * fix checkboxes and add API for deleting backup runs * better styling for checkboxes * small button in ssh kpage too * complete multiple UI launcher * fix actions * present error toast too * fix target forms
MattDHill
added a commit
that referenced
this pull request
Jun 12, 2023
* initial restructuring * very cool * new structure in place * delete unnecessary T * down the rabbit hole * getting better * dont like it * nice * very nice * sessions select all * nice * backup runs * fix targets and more * small improvements * mostly working * address PR comments * fix error * delete issue with merge * fix checkboxes and add API for deleting backup runs * better styling for checkboxes * small button in ssh kpage too * complete multiple UI launcher * fix actions * present error toast too * fix target forms
dr-bonez
pushed a commit
that referenced
this pull request
Jun 23, 2023
* initial restructuring * very cool * new structure in place * delete unnecessary T * down the rabbit hole * getting better * dont like it * nice * very nice * sessions select all * nice * backup runs * fix targets and more * small improvements * mostly working * address PR comments * fix error * delete issue with merge * fix checkboxes and add API for deleting backup runs * better styling for checkboxes * small button in ssh kpage too * complete multiple UI launcher * fix actions * present error toast too * fix target forms
MattDHill
added a commit
that referenced
this pull request
Jun 25, 2023
* initial restructuring * very cool * new structure in place * delete unnecessary T * down the rabbit hole * getting better * dont like it * nice * very nice * sessions select all * nice * backup runs * fix targets and more * small improvements * mostly working * address PR comments * fix error * delete issue with merge * fix checkboxes and add API for deleting backup runs * better styling for checkboxes * small button in ssh kpage too * complete multiple UI launcher * fix actions * present error toast too * fix target forms
dr-bonez
pushed a commit
that referenced
this pull request
Jul 6, 2023
* initial restructuring * very cool * new structure in place * delete unnecessary T * down the rabbit hole * getting better * dont like it * nice * very nice * sessions select all * nice * backup runs * fix targets and more * small improvements * mostly working * address PR comments * fix error * delete issue with merge * fix checkboxes and add API for deleting backup runs * better styling for checkboxes * small button in ssh kpage too * complete multiple UI launcher * fix actions * present error toast too * fix target forms
dr-bonez
pushed a commit
that referenced
this pull request
Jul 7, 2023
update FE types and unify sideload page with marketplace show begin popover for UI launch select update node version for github workflows fix type errors eager load more components fix mocks for types recalculate updates bad on pkg uninstall chore: break form-object file structure files for config finish file upload API and implement for config chore: break down form-object by type, part 1 remove NEW from config comment entire setTimeout for new generic form options chore: break down form-object by type, part 2 headers for enums and unions implement select and multiselect for config update union types and camel case for specs implement textarea config value inputspec and required instead of nullable remove subtype from list spec update start-sdk bump start-sdk feat: use Taiga UI for config modal (#2250) * feat: use Taiga UI for config modal * chore: finish remaining changes * chore: address comments * bump sdk version --------- Co-authored-by: Matt Hill <[email protected]> update package lock update to sdk 20 and fix types chore: update Taiga UI and migrate some more forms (#2252) update form to latest sdk validate length for textarea too chore: accommodate new changes to the specs (#2254) * chore: accommodate new changes to the specs * chore: fix error * chore: fix error feat: add input color (#2257) * feat: add input color * patterns will always be there --------- Co-authored-by: Matt Hill <[email protected]> chore: properly type pattern error update to latest sdk Add sans-serif font fallback (#2263) * Add sans-serif font fallback * Update frontend readme start scripts feat: add datetime spec support (#2264) Wifi optional (#2249) * begin work * allow enable and disable wifi * nice styling * done except for popover not dismissing * update wifi.ts * address comments Feat/automated backups (#2142) * initial restructuring * very cool * new structure in place * delete unnecessary T * down the rabbit hole * getting better * dont like it * nice * very nice * sessions select all * nice * backup runs * fix targets and more * small improvements * mostly working * address PR comments * fix error * delete issue with merge * fix checkboxes and add API for deleting backup runs * better styling for checkboxes * small button in ssh kpage too * complete multiple UI launcher * fix actions * present error toast too * fix target forms Add logs window to setup wizard loading screen (#2076) * add logs window to setup wizard loading screen * fix type error * Update frontend/projects/setup-wizard/src/app/services/api/live-api.service.ts Co-authored-by: Lucy C <[email protected]> --------- Co-authored-by: Lucy C <[email protected]> statically type server metrics and use websocket (#2124) Co-authored-by: Matt Hill <[email protected]> Feat/external-smtp (#1791) * UI for EOS smtp, missing API layer * implement api * fix errors * switch to external smtp creds * fix things up * fix types * update types for new forms * feat: add new form to emails and marketplace (#2268) * import tuilet module * feat: get rid of old form completely (#2270) * move to builder spec and delete developer menu * update sdk * tiny * getting better * working * done * feat: add step to number config * chore: small fixes * update SDK and step for numbers --------- Co-authored-by: Alex Inkin <[email protected]> latest sdk, fix build update SDK for better disabled props feat: implement `disabled`, `immutable` and `generate` (#2280) * feat: implement `disabled`, `immutable` and `generate` * chore: remove unnecessary code * chore: add generate to textarea and implement immutable * no generate for textarea --------- Co-authored-by: Matt Hill <[email protected]> update lockfile refactor: extract loading status to shared library (#2282) * refactor: extract loading status to shared library * chore: remove inline style refactor: break routing down to apps level (#2285) closes #2212 and closes #2214 Feat/credentials (#2290) add credentials and remove properties refactor: break ui up further down (#2292) * refactor: break ui up further down * permit loading even when authed --------- Co-authored-by: Matt Hill <[email protected]> update patchdb for package compatability fixes fix file structure WIP finish rebase mvp complete port forwards mvp looking good cleaner system page move experimental features manual port overrides better info headers for jobs pages refactor: move diagnostic-ui app under ui route (#2306) * refactor: move diagnostic-ui app under ui route * chore: hide navigation * chore: remove ionic from diagnostic * fix navbar showing on login --------- Co-authored-by: Matt Hill <[email protected]> chore: partially remove ionic modals and loaders (#2308) * chore: partially remove ionic modals and loaders * change to snake --------- Co-authored-by: Matt Hill <[email protected]> better session data fetching abstract store icon component to shared marketplace project (#2311) * abstract store icon component to shared marketplace project * better than using a pipe * minor cleanup * chore: fix missing node types in libraries * typo --------- Co-authored-by: Matt Hill <[email protected]> Co-authored-by: waterplea <[email protected]> refactor: continue to get rid of ionic infrastructure (#2325) refactor: finish removing ionic entities: (#2333) * refactor: finish removing ionic entities: ToastController ErrorToastService ModalController AlertController LoadingController * chore: rollback testing code * chore: fix comments * minor form change * chore: fix comments * update clearnet address parts * move around patchDB * chore: fix comments --------- Co-authored-by: Matt Hill <[email protected]> fixup after rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.