Correctly handle unicode data in the HTTP runner #4601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP runner didn't correctly handle
data
argument when it was an unicode string. When providing a textual (non-object / dictionary) data,requests
expects bytes and not unicode type and that's what we should pass to the function to make it work correctly.Before:
After:
I confirmed the fix under Python 2.7 and Python 3.6.
Resolves #4599.
Thanks to @kknyxkk and @rsmartins78 for reporting this.
TODO