Various Python 3 related fixes and changes #4424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
script. This way user can also use Python 3 virtualenv for launchdev.
options are not set.
each BlockingScheduler class constructor.
registered as common options inside st2common.
advertised. We advertise "timersengine" section as new and preferred way of configuring timers engine service and "timer" config options are deprecated. Because of the way how the code was structured[1], even if user would specify only "timersengine" section in st2.conf, those options would not be used, but default options from config.py for "timer" section would be used. This pull request fixes that to work as advertised / inteded - "timer" section should only be used if explicitly specified in st2.conf and timersengine should have precedence over it. [1]: https://github.com/StackStorm/st2/blob/0245a18198babafe2ab0abde31791cf526435234/st2reactor/st2reactor/cmd/timersengine.py#L59
|
And for people who want to test Python 3 stuff locally, they can now do this: make requirements
source virtualenv/bin/activate # this is needed to ensure latest version of virtualenv binary is used by Python 3 aka Python 2 virtual environment needs to exist already
PYTHON_VERSION=python3.6 VIRTUALENV_DIR=virtualenv-py3 make requirements
source virtualenv-py3/bin/activate
VIRTUALENV=virtualenv-py3 ./tools/launchdev.sh startThis will create a new virtual environment using Python 3.6 binary and start all the services using this new virtual environment. Keep in mind that this command requires Python 3.6, python3-virtualenv, etc. be installed on the system. |
| @@ -13,7 +13,7 @@ else | |||
| VIRTUALENV_ST2CLIENT_DIR ?= virtualenv-st2client | |||
| endif | |||
|
|
|||
| PYTHON_VERSION = python2.7 | |||
| PYTHON_VERSION ?= python2.7 | |||
There was a problem hiding this comment.
Wow. Things you learn :)
| # NOTE: "timer" section will be removed in v3.1 | ||
| timer_opts = [ | ||
| cfg.StrOpt( | ||
| 'local_timezone', default=None, |
There was a problem hiding this comment.
I read the original code and default=True for both timers and timersengine was pretty dumb on my part. I now get what you mean. Good catch.
lakshmi-kannan
approved these changes
Nov 5, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I uncovered some more Python 3 related issues while working on Bionic pacakges.
This pull request includes the following changes / fixes:
st2garbagecollectorservice to launchdev scriptVIRTUALENVenvironment variable - this allows people to use it with a Python 3 virtual environmentst2-pack-installso it works under Python 3timezonekwarg toBlockingSchedulerclass constructor