Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about invalid format in pip list #4380

Merged
merged 4 commits into from
Oct 18, 2018

Conversation

nmaludy
Copy link
Member

@nmaludy nmaludy commented Oct 8, 2018

In recent versions of pip, the legacy format has been removed causing the following warning when running st2-run-pack-tests:

Installing dependencies from st2 repository...

Usage:   
  pip list [options]

option --format: invalid choice: 'legacy' (choose from 'columns', 'freeze', 'json')
Installing global pack test dependencies...
Installing pack-specific dependencies...
Installing pack-specific test dependencies..

This PR fixes the issue by using the freeze format instead of legacy.

@Kami
Copy link
Member

Kami commented Oct 16, 2018

Is freeze also supported in older versions of pip where we used legacy?

@Kami Kami added this to the 3.0.0 milestone Oct 16, 2018
Copy link

@laixintao laixintao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Kami
Copy link
Member

Kami commented Oct 17, 2018

Confirmed freeze format is also available in older versions of pip (we pin to 9.x in various places).

@laixintao
Copy link

I tested in 10.x and 18.x

@Kami
Copy link
Member

Kami commented Oct 17, 2018

@laixintao Thanks for confirming.

I need to wait with merging this PR (and other PRs) a bit until we sort out our CI issue - we spun up a new instance, but webhooks were not set up correctly so end to end tests are not running on Github commit / push.

@Kami Kami self-assigned this Oct 17, 2018
@Kami Kami merged commit a2bf25e into StackStorm:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants