Update st2-pack-install command so it allows users to install packs from local git repos in a detached head state #4366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disk which are in a detached head state (e.g. specific commit is checked out).
👍 |
arm4b
reviewed
Sep 28, 2018
| @@ -151,7 +151,22 @@ def clone_repo(temp_dir, repo_url, verify_ssl=True, ref='master'): | |||
| # because we want the user to work with the repo in the | |||
| # future. | |||
| repo = Repo.clone_from(repo_url, temp_dir) | |||
| active_branch = repo.active_branch | |||
|
|
|||
| is_local_repo = repo_url.startswith('file:///') | |||
There was a problem hiding this comment.
File URI can be with just 2 starting slashes in it like file://localhost/some/local/dir, see https://en.wikipedia.org/wiki/File_URI_scheme
There was a problem hiding this comment.
Yeah, I don't think rest of our pack management code code supports that though :)
There was a problem hiding this comment.
$ st2 pack install file://localhost/home/vagrant/stackstorm-consul
[ succeeded ] download pack
[ succeeded ] make a prerun
[ succeeded ] install pack dependencies
[ succeeded ] register pack
+-------------+---------+
| Property | Value |
+-------------+---------+
| name | consul |
| description | consul |
| version | 0.6.5 |
| author | jfryman |
+-------------+---------+
There was a problem hiding this comment.
You are correct - we didn't have any tests cases so I assume it's not supported / doesn't work.
Will make a change and add a test case.
bigmstone
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates
st2-pack-installcommand to allow users install packs from a local directory on disk (file:///<path>) which are in a detached head state - aka user already checked out a specific commit / revision.Fixes StackStorm/st2packs-dockerfiles#4.
TODO