-
Notifications
You must be signed in to change notification settings - Fork 36
TASK-6411 IPv6 improvements, draft 5.1 changelog #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for support-docs failed.
|
title: "Category File" | ||
type: "custom" | ||
name: "Momentum 5.x Changelogs" | ||
description: "Momentum 5.x Changelogs" | ||
--- | ||
|
||
* [Momentum 5.0 Changelogs](/momentum/changelog/5/5-0) | ||
* [Momentum 5.1 Changelogs](/momentum/changelog/5/5-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please point me to where 5-1 changelog is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added it.
@@ -16,15 +16,15 @@ The following example demonstrates how to configure Momentum to pass LOGIN crede | |||
``` | |||
# Configure the RADIUS client | |||
auth_radius { | |||
NAS-IP-Address = 10.0.0.1 # the IP address of this SMTP server | |||
NAS-IP-Address = fd01:345::1 # the IP address of this SMTP server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we test with IPv6 address? If not, we shall keep the example in IPv4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was asked to add IPv6 examples.
server "two" { | ||
host = "radius-2.example.com" | ||
server "ipv6wport" { | ||
host = "[2001:fd3::1]:2812" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can keep the example in IPv4.
@@ -85,7 +85,7 @@ RADIUS servers can be defined using the dictionary syntax shown above; the dicti | |||
|
|||
<dd> | |||
|
|||
The hostname or IP address of the RADIUS server. If a colon is present in the string then the left side of the string will be used as the hostname/IP address and the right hand side will be used as the port number on the server. If left unspecified, the RADIUS standard port number of 1812 will be used. | |||
The hostname or IP address of the RADIUS server. The hostname/IP address can be followed by a colon and the port number on the server. If left unspecified, the RADIUS standard port number of 1812 will be used. An IPv6 address must be enclosed in brackets if a port was added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can mention that since 5.1, IPv6 address can be used but must be enclosed in bracket if a port is specified.
What Changed
How To Test or Verify
PR Checklist
Below are some checklists to follow for the correct procedure in different circumstance. The first list ("All PRs Checklist") should be followed for ALL PRs. The next 2 are additive to this list depending on what type of PR you are using.
For example: If you are submitting a content change to one of the support documents, your checklist would include the:
If you are submitting a feature addition, enhancement, or bug fix, your checklist would include the:
All PRs Checklist
team-FE
orteam-SAZ
)Content Changes Checklist
examples/article.md
in the root of the project directory and on the momentum doc's preface articleDevelopment Changes Checklist (some checks are automatic github actions and will not be listed here. ie. "all tests pass")
cypress/
directory in the root of the project