Fixes how profdata_coverage_dir is created. #145
Conversation
The previous implementation of this method was assuming that the first product always has name, which doesn't always happen. The documentation of PBXFileReference says that the 'name' attribute is "often not present.". For more info check https://github.com/CocoaPods/Xcodeproj/blob/master/lib/xcodeproj/project/object/file_reference.rb#L13 If the name attribute is not present the profdata_coverage_dir created was the first child of the build directory (which by default is the derived data directory). This is wrong. Also the build directory was being concatenated using plain string manipulation which led to path of the form: "~/Library/Developer/Xcode/DerivedData//**/PRODUCT_NAME". This is why File.join is used to join the build directory path with '/**/PRODUCT_NAME' to comtemplate the case of build directory already ending with '/'.
In order to mimic how xcodebuild uses the derived data directory the project names should be appended to TEMP_DERIVED_DATA_PATH. This fixes most of the failing tests.
|
@neonichu Coud you help me fix the remaining tests? The problems seems to be that the mocked scheme is wrong. The mocked scheme is "FixtureScheme" and should be "fixtures" |
|
@maintainer @neonichu Can anyone take a look at this? I can fix the failing tests if you provide me some insights about them. Also what do you guys think about this changes? |
|
Thanks for the PR! I agree with you that the mocked scheme should actually be different. The last test is failing because the expectation wasn't updated with new path: https://travis-ci.org/SlatherOrg/slather/builds/108183974#L324 |
|
@neonichu Tests are passing now 😄 !!! Let me know if this is ready to be merged. In such case, Would you mind cutting a new release? |
|
Nice, would you mind adding an entry to the Changelog as well? |
|
@neonichu Done! |
Fixes how profdata_coverage_dir is created.
|
Thanks a lot for the contribution! |
|
🎉 |
Version
2.0.0of this gem fails with the following error in my projectrunning with verbose flag generated the following output
As it can be seen the binary file was pointing to another project (a dependency of my project, Syrmo, to be precise). After some debugging I found that the cause of this error was related with how
profdata_coverage_dirwas created.