This repository was archived by the owner on Feb 22, 2020. It is now read-only.
Add and use HashCode polyfill #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PING @JimBobSquarePants |
|
Any idea what’s going wrong with the unit tests? |
|
Oh, I'm dumb. Was running the tests against NETCORE2.1. Fix coming! |
|
And fixed! |
|
@JimBobSquarePants OK, I think all is well now. Made a super dumb mistake. :) |
|
@JimBobSquarePants Do we even need the TypeForwardedFor attributes? |
As far as I'm aware they are an absolute requirement to prevent ambiguous reference exceptions. |
JimBobSquarePants
approved these changes
Dec 9, 2018
|
Once this lands on MyGET, I'll do a pass on ImageSharp to get everything updated. |
antonfirsov
pushed a commit
to SixLabors/ImageSharp
that referenced
this pull request
Jan 19, 2020
Add and use HashCode polyfill
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR polyfills the HashCode implementation using the same logic as MathF.