fix: fixing issue with getting user data

[neelneelneel]

Description

Fix with pulling members

[github-actions]

@CodiumAI-Agent /describe

[CodiumAI-Agent]

Title

fix: fixing issue with getting user data

---

User description

Description

Fix with pulling members

---

PR Type

Bug fix

---

Description

Use debouncedSearch for member queries
Compute dynamic pagination offset and limit
Remove unused imports (useLayoutEffect, Badge)

---

Changes walkthrough 📝

	Relevant files
Bug fix	MembersTable.tsx Update MembersTable API pagination parameters                        packages/client/src/components/settings/MembersTable.tsx Removed unused imports (useLayoutEffect, Badge) Replaced configStore.store.user.id with debouncedSearch Calculated offset and limit dynamically from page and rowsPerPage +4/-5

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

@CodiumAI-Agent /review

[github-actions]

@CodiumAI-Agent /improve

[CodiumAI-Agent]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review API Parameter Mismatch The new getEngineUsers call replaced configStore.store.user.id with debouncedSearch but it’s unclear if the API signature supports this ordering. Confirm that the backend client expects (adminMode, id, searchTerm, permission, offset, limit) and not the previous (adminMode, id, userId, permission, offset, limit). getMembersApi = [ 'getEngineUsers', adminMode, id, debouncedSearch ? debouncedSearch : undefined, permissionPriorityMapper(permissionFilter)?.permission, (page + 1) * rowsPerPage - rowsPerPage, // offset rowsPerPage, // limit ]; Offset Calculation The offset is computed as (page + 1) * rowsPerPage - rowsPerPage which is equivalent to page * rowsPerPage but less clear. Consider simplifying the expression to avoid potential arithmetic mistakes. (page + 1) * rowsPerPage - rowsPerPage, // offset rowsPerPage, // limit

[CodiumAI-Agent]

PR Code Suggestions ✨

Latest suggestions up to b91f439

Category	Suggestion	Impact
Possible issue	Restore user ID argument The search argument replaced the configStore.store.user.id parameter in the array, likely breaking the API signature; reinsert the user ID as the fourth element and then pass debouncedSearch as its own argument. packages/client/src/components/settings/MembersTable.tsx [305] +configStore.store.user.id, debouncedSearch ? debouncedSearch : undefined, Suggestion importance[1-10]: 9 __ Why: The removal of configStore.store.user.id likely breaks the API signature, re-inserting it ensures correct parameter order.	High
General	Simplify offset calculation Simplify the offset calculation by using page * rowsPerPage to improve readability and avoid redundant arithmetic. packages/client/src/components/settings/MembersTable.tsx [307] -(page + 1) * rowsPerPage - rowsPerPage, // offset +page * rowsPerPage, // offset Suggestion importance[1-10]: 4 __ Why: Using page * rowsPerPage is equivalent and improves readability with no change in functionality.	Low

---

Previous suggestions

Suggestions up to commit b91f439

Category	Suggestion	Impact
Possible issue	Restore correct argument order Ensure that configStore.store.user.id is restored as the third argument and move debouncedSearch to the fourth slot to match the expected signature of getEngineUsers. This prevents replacing the user ID with the search term inadvertently. packages/client/src/components/settings/MembersTable.tsx [304-305] id, +configStore.store.user.id, debouncedSearch ? debouncedSearch : undefined, Suggestion importance[1-10]: 9 __ Why: Restoring configStore.store.user.id between id and the search term prevents breaking the expected API signature and fixes a critical bug.	High
General	Default empty search string Use a fallback to an empty string for debouncedSearch instead of undefined to ensure the API always receives a consistent string type. packages/client/src/components/settings/MembersTable.tsx [305] -debouncedSearch ? debouncedSearch : undefined, +debouncedSearch || '', Suggestion importance[1-10]: 5 __ Why: Using an empty string ensures a consistent string type for the search parameter but only has minor impact on API behavior.	Low
	Simplify offset calculation Simplify the offset calculation to page * rowsPerPage for clarity and to avoid potential arithmetic mistakes. packages/client/src/components/settings/MembersTable.tsx [307] -(page + 1) * rowsPerPage - rowsPerPage, // offset +page * rowsPerPage, // offset Suggestion importance[1-10]: 4 __ Why: Simplifying (page + 1) * rowsPerPage - rowsPerPage to page * rowsPerPage improves clarity with no functional change.	Low

[johbaxter]

In a PR where we do code cleanup, please use correct api to get user data instead of indexing

[github-actions]

@CodiumAI-Agent /update_changelog