-
Notifications
You must be signed in to change notification settings - Fork 10
feat(client): show loading skeleton #1218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): show loading skeleton #1218
Conversation
@CodiumAI-Agent /describe |
Titlefeat(client): show loading skeleton User descriptionDescriptionshow loading skeleton. Changes Made1.Modified HomePage.tsx How to Test
NotesPR TypeEnhancement Description
Changes walkthrough 📝
|
@CodiumAI-Agent /review |
@CodiumAI-Agent /improve |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use the semoss-ui components before importing from mui
@@ -19,6 +19,7 @@ import { Search } from '@mui/icons-material'; | |||
import { Help } from '@/components/help'; | |||
|
|||
import { Filterbox } from '@/components/ui'; | |||
import Skeleton from '@mui/material/Skeleton'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
semoss ui has a skeleton that I think it would be better if you used.
…leton-while-it-gets-app-images
…leton-while-it-gets-app-images
…leton-while-it-gets-app-images
@CodiumAI-Agent /update_changelog |
Changelog updates: 🔄 2025-06-05 *Added
|
Description
show loading skeleton.
Changes Made
1.Modified HomePage.tsx
How to Test
Go to App Landing Page -> Refresh the page
Loading skeleton while it gets app images
Notes