feat(client): changes made to remove iscustomgroup and usages (#839) #1210

Subhadeepghosh1 · 2025-05-23T12:42:02Z

Description:
changes made to remove isCustomGroup and Usages

Changes Made:

TeamTileCard.tsx
monolith.store.tsx
TeamsSettingsPage.tsx
AddTeamModal.tsx

github-actions · 2025-05-23T12:42:12Z

@CodiumAI-Agent /describe

CodiumAI-Agent · 2025-05-23T12:42:44Z

Title

feat(client): changes made to remove iscustomgroup and usages (#839)

User description

Description:
changes made to remove isCustomGroup and Usages

Changes Made:

TeamTileCard.tsx
monolith.store.tsx
TeamsSettingsPage.tsx
AddTeamModal.tsx

PR Type

Enhancement

Description

Remove isCustomGroup flag and usages
Simplify addTeam/editTeam method signatures
Use type property for custom groups
Clean up modal, card, and settings props

Changes walkthrough 📝

Relevant files

Enhancement

AddTeamModal.tsx `Simplify add/edit team modal calls` packages/client/src/components/teams/AddTeamModal.tsx Remove conditional ternary on isCustomGroup Call `monolithStore.addTeam`/`editTeam` with `data.TEAM_TYPE` Drop boolean parameter usage entirely	+10/-26
TeamTileCard.tsx `Remove isCustomGroup checks in card` packages/client/src/components/teams/TeamTileCard.tsx Drop `isCustomGroup` prop destructuring Replace checks with `type === 'Custom'` Adjust menu and user loading logic	+3/-14
TeamsSettingsPage.tsx `Omit isCustomGroup prop on cards` packages/client/src/pages/settings/TeamsSettingsPage.tsx Remove `isCustomGroup={team.is_custom_group}` prop Rely on `type` for group behavior	+0/-1
monolith.store.ts `Simplify addTeam/editTeam store methods` packages/client/src/stores/monolith/monolith.store.ts Remove `isCustomGroup` parameter Update signatures to accept `type` only Drop related URL query param	+2/-16

Need help?
Type /help how to ... in the comments thread for any questions about PR-Agent usage.
Check out the documentation for more information.

github-actions · 2025-05-23T12:42:58Z

@CodiumAI-Agent /review

github-actions · 2025-05-23T12:43:43Z

@CodiumAI-Agent /improve

CodiumAI-Agent · 2025-05-23T12:43:49Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Backend Compatibility Verify that replacing `isCustomGroup` with a `type` query parameter is supported by backend endpoints and that `type=Custom` is interpreted correctly to maintain existing behavior. async addTeam(groupId: string, description: string, type?: string) { let url = `${Env.MODULE}/api/auth/admin/`, postData = ''; url += 'group/addGroup'; postData += 'groupId=' + encodeURIComponent(groupId); postData += '&description=' + encodeURIComponent(description); if (type) { postData += '&type=' + encodeURIComponent(type); } const response = await axios.post<{ success: boolean }>(url, postData, { headers: { 'content-type': 'application/x-www-form-urlencoded', }, }); return response; } /** * @name editTeam * @param groupId * @param description * @param type * @returns / async editTeam(groupId: string, description: string, type?: string) { Props Interface* Ensure that `TeamCardProps` is updated to include the `type` property (and any other needed props like `tag`) so the destructuring in `TeamTileCard` is valid and no runtime errors occur. /** dispatch function / dispatch: (val: { type: string; field: string; value: unknown[] }) => void; /* databases to update */ teams; onClick?: (value: string) => void; } const StyledModalTitle = styled(Modal.Title)(({ theme }) => ({

CodiumAI-Agent · 2025-05-23T12:45:17Z

PR Code Suggestions ✨

Category	Suggestion	Impact
Possible issue	Await API call errors Replace the promise `.then()` chain with `await` so that errors thrown by `editTeam` bubble into the surrounding `try/catch`. This ensures API failures are properly handled and simplifies control flow. packages/client/src/components/teams/AddTeamModal.tsx [184-188] -const editResponse = monolithStore.editTeam( +const response = await monolithStore.editTeam( data.TEAM_NAME, data.TEAM_DESCRIPTION, data.TEAM_TYPE, ); Suggestion importance[1-10]: 8 __ Why: The suggestion improves error handling by ensuring errors in `editTeam` are caught in the existing `try/catch` and simplifies the promise chain.	Medium
General	Build payload with URLSearchParams Use `URLSearchParams` to assemble the request body instead of manual string concatenation. This avoids mistakes with separators or encoding and makes the code more maintainable. packages/client/src/stores/monolith/monolith.store.ts [1070-1078] -let postData = ''; -postData += 'groupId=' + encodeURIComponent(groupId); -postData += '&description=' + encodeURIComponent(description); +const params = new URLSearchParams({ + groupId: groupId, + description: description, +}); if (type) { - postData += '&type=' + encodeURIComponent(type); + params.append('type', type); } +const postData = params.toString(); Suggestion importance[1-10]: 5 __ Why: Using `URLSearchParams` makes assembling the request body more concise, avoids manual string concatenation mistakes, and enhances maintainability.	Low
General	Extract custom group flag Extract the `type === 'Custom'` check into a boolean constant like `isCustomGroup` at the top of the component. This avoids magic strings and repeated logic, improving readability. packages/client/src/components/teams/TeamTileCard.tsx [323] -if (type === 'Custom') { +const isCustomGroup = type === 'Custom'; +if (isCustomGroup) { Suggestion importance[1-10]: 4 __ Why: Defining `isCustomGroup` removes the magic string, improves readability, and allows reusing the boolean check throughout the component.	Low

AAfghahi

I like that we are putting type into the pixel call, seems a lot cleaner.

AAfghahi · 2025-05-25T22:49:29Z

packages/client/src/components/teams/TeamTileCard.tsx

@@ -331,7 +320,7 @@ export const TeamTileCard = (props: TeamCardProps) => {
            return;
        }
        setIsLoading(true);
-        if (isCustomGroup) {
+        if (type === 'Custom') {


what's the difference btwn isCustomGroup and type=== 'Custom'

…m/SEMOSS/semoss-ui into 839-Remove_isCustomGroupAndUsages

AAfghahi · 2025-06-04T13:43:01Z

packages/client/src/components/teams/AddTeamModal.tsx

-                        color: 'success',
-                        message: 'Successfully updated team',
-                    });
+                onClose({


this should do some error checking.

AAfghahi · 2025-06-09T19:40:42Z

packages/client/src/components/teams/AddTeamModal.tsx

+                    color: 'success',
+                    message: 'Successfully updated team',
+                });
+            } catch (e) {


Another check you should do is to check if OPERATION is equal to Error, sometimes the pixel shows up at as having passed, but it is still an error in the pixel call.

AAfghahi · 2025-06-09T19:40:59Z

packages/client/src/components/teams/AddTeamModal.tsx

-                    );
+                    },
+                );
+            } catch (e) {


…move_isCustomGroupAndUsages

…m/SEMOSS/semoss-ui into 839-Remove_isCustomGroupAndUsages

github-actions · 2025-06-19T09:11:46Z

@CodiumAI-Agent /update_changelog

CodiumAI-Agent · 2025-06-19T09:12:21Z

Changelog updates: 🔄

2025-06-19 *

Changed

Removed isCustomGroup flag and related logic from team UI components and store
Refactored team add/edit flows to use async/await and unified type handling (CUSTOM)

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

feat(client): changes made to remove iscustomgroup and usages (#839)

Loading
Loading status checks…

6232d4b

Subhadeepghosh1 requested review from anurag91jain, AAfghahi and johbaxter May 23, 2025 12:42

Subhadeepghosh1 self-assigned this May 23, 2025

Subhadeepghosh1 requested a review from a team as a code owner May 23, 2025 12:42

Merge branch 'dev' into 839-Remove_isCustomGroupAndUsages

Loading
Loading status checks…

62cb310

AAfghahi reviewed May 25, 2025

View reviewed changes

Subhadeepghosh1 added 2 commits May 26, 2025 21:49

feat(client): changes made to remove iscustomgroup and usages (#839)

79453d3

Merge branch '839-Remove_isCustomGroupAndUsages' of https://github.co…

Loading
Loading status checks…

33dc532

…m/SEMOSS/semoss-ui into 839-Remove_isCustomGroupAndUsages

anurag91jain linked an issue May 26, 2025 that may be closed by this pull request

Remove is_custom_group field and related usages SEMOSS/Semoss#839

Closed

AAfghahi approved these changes May 28, 2025

View reviewed changes

AAfghahi and others added 2 commits May 28, 2025 15:21

Merge branch 'dev' into 839-Remove_isCustomGroupAndUsages

Loading
Loading status checks…

ac53565

Changing logic from .then to async await

Loading
Loading status checks…

685f886

neelneelneel force-pushed the dev branch from 4328fb0 to 6eebd69 Compare May 30, 2025 22:46

AAfghahi reviewed Jun 4, 2025

View reviewed changes

AAfghahi and others added 2 commits June 4, 2025 07:43

Merge branch 'dev' into 839-Remove_isCustomGroupAndUsages

Loading
Loading status checks…

56038aa

feat(client): making try catch precise for updating and creating team

Loading
Loading status checks…

f830e14

anurag91jain approved these changes Jun 9, 2025

View reviewed changes

Merge branch 'dev' into 839-Remove_isCustomGroupAndUsages

Loading
Loading status checks…

155d2b5

AAfghahi reviewed Jun 9, 2025

View reviewed changes

anurag91jain added 3 commits June 13, 2025 14:58

Merge branch 'dev' of https://github.com/SEMOSS/semoss-ui into 839-Re…

Loading
Loading status checks…

9ac05b8

…move_isCustomGroupAndUsages

feat(client): changes for removing isCustomGroup

Loading
Loading status checks…

44c953b

feat(client): fixing type to be sent to edit modal

Loading
Loading status checks…

c10be2b

anurag91jain and others added 5 commits June 16, 2025 15:47

feat(client): fixing soft error scenarios from BE

2fb66b3

Merge branch 'dev' into 839-Remove_isCustomGroupAndUsages

Loading
Loading status checks…

417c87c

Merge branch '839-Remove_isCustomGroupAndUsages' of https://github.co…

Loading
Loading status checks…

599d798

…m/SEMOSS/semoss-ui into 839-Remove_isCustomGroupAndUsages

feat(client): removing unused import

Loading
Loading status checks…

169dc96

Merge branch 'dev' into 839-Remove_isCustomGroupAndUsages

Loading
Loading status checks…

0fc1dc3

anurag91jain merged commit 91cad43 into dev Jun 19, 2025
3 checks passed

anurag91jain deleted the 839-Remove_isCustomGroupAndUsages branch June 19, 2025 09:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(client): changes made to remove iscustomgroup and usages (#839) #1210

feat(client): changes made to remove iscustomgroup and usages (#839) #1210

Subhadeepghosh1 commented May 23, 2025

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

CodiumAI-Agent commented May 23, 2025

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

CodiumAI-Agent commented May 23, 2025

Uh oh!

CodiumAI-Agent commented May 23, 2025

Uh oh!

AAfghahi left a comment

Uh oh!

AAfghahi May 25, 2025

Uh oh!

AAfghahi Jun 4, 2025

Uh oh!

anurag91jain Jun 9, 2025

Uh oh!

AAfghahi Jun 9, 2025

Uh oh!

AAfghahi Jun 9, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 19, 2025

Uh oh!

CodiumAI-Agent commented Jun 19, 2025

Uh oh!

feat(client): changes made to remove iscustomgroup and usages (#839) #1210

feat(client): changes made to remove iscustomgroup and usages (#839) #1210

Conversation

Subhadeepghosh1 commented May 23, 2025

Uh oh!

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

CodiumAI-Agent commented May 23, 2025

Title

User description

PR Type

Description

Changes walkthrough 📝

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

CodiumAI-Agent commented May 23, 2025

PR Reviewer Guide 🔍

Uh oh!

CodiumAI-Agent commented May 23, 2025

PR Code Suggestions ✨

Uh oh!

Uh oh!

AAfghahi left a comment

Choose a reason for hiding this comment

Uh oh!

AAfghahi May 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AAfghahi Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

anurag91jain Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AAfghahi Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

AAfghahi Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 19, 2025

Uh oh!

CodiumAI-Agent commented Jun 19, 2025

2025-06-19 *

Changed

Uh oh!