-
Notifications
You must be signed in to change notification settings - Fork 10
feat(client): save the last edited date #1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@CodiumAI-Agent /describe |
Titlefeat(client): save the last edited date User descriptionDescriptionSave Last edited Date Changes Made1.Modified AppTileCard.tsx How to Test
NotesPR TypeEnhancement Description
Changes walkthrough 📝
|
@CodiumAI-Agent /review |
@CodiumAI-Agent /improve |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨
|
const lastEditedDate = useMemo(() => { | ||
const d = dayjs(app.project_date_last_edited); | ||
if (!d.isValid()) { | ||
return `Last Edited ${dayjs().format('MMMM D, YYYY')}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If date is not valid, set it to null. Similarly do it for createdDate.
@@ -432,6 +440,12 @@ export const AppTileCard = (props: AppTileCardProps) => { | |||
{createdDate} | |||
</StyledPublishedByLabel> | |||
</StyledPublishedByContainer> | |||
<StyledPublishedByContainer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Render this only if the lastEditedDate is present. Do the same for createdDate
@@ -253,12 +253,20 @@ export const AppTileCard = (props: AppTileCardProps) => { | |||
const createdDate = useMemo(() => { | |||
const d = dayjs(app.project_date_created); | |||
if (!d.isValid()) { | |||
return `Published ${dayjs().format('MMMM D, YYYY')}`; | |||
return ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @anurag91jain that this should be returning null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still do not like returning an empty string instead of null
@CodiumAI-Agent /update_changelog |
Changelog updates: 🔄 2025-06-06 *Added
|
Description
Save Last edited Date
Changes Made
1.Modified AppTileCard.tsx
2.Added project_date_last_edited in 4 files
How to Test
Go to App Landing Page
You will be able to see published and last edited dates.
Notes