You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reliance on window.history.length for SPA navigation may be unreliable across browsers or user flows; consider using React Router methods to detect navigation history or fallback conditions consistently.
Replace the unreliable window.history.length check with React Router's history.state.idx property to determine if a back navigation is possible. This ensures the fallback logic works correctly in an SPA.
Why: Using window.history.length can be unreliable in an SPA; checking window.history.state?.idx aligns with React Router’s internal indexing and improves back‐navigation accuracy.
Medium
General
Use replace option for navigate
Add the { replace: true } option to both navigate calls to avoid creating extra history entries when performing back or fallback navigation.
Why: Adding { replace: true } on the fallback navigate('/') avoids an extra entry, but it's redundant on navigate(-1) since back navigation doesn’t push a new history entry.
Replace the unreliable window.history.length check with React Router's history.state.idx property to determine if a back navigation is possible. This ensures the fallback logic works correctly in an SPA.
Why: Using window.history.length can be unreliable in an SPA; checking window.history.state?.idx aligns with React Router’s internal indexing and improves back‐navigation accuracy.
Medium
General
Use replace option for navigate
Add the { replace: true } option to both navigate calls to avoid creating extra history entries when performing back or fallback navigation.
Why: Adding { replace: true } on the fallback navigate('/') avoids an extra entry, but it's redundant on navigate(-1) since back navigation doesn’t push a new history entry.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes Made
How to Test
Notes