[BUG] My Discoverable Projects/Engines - No Favorites Version

[themaherkhalil]

A clear and concise description of what the issue is.

There are no favorited (bookmarked) apps or engines that are discoverable. The FE makes the call passing in favorites=true but in reality this filter is never used by the BE and the same list of apps/engines is returned in both calls.

How to reproduce the issue

1. Create an app or engine
2. Make it discoverable
3. Remove your access to the app or engine
4. Go back to the proper catalog page - go into discoverable tab
5. Favorites section / call should not be made

[johbaxter]

@phkem

At the end of the day, there is no concept of Favorited Discoverable apps.

On the FE we make a Reactor Call to get Favorited Apps when switching to the discoverable tab. We shouldn't make that extra frontend call for MyDiscoverableProjects(onlyFavorites=[true]).

But to also answer your question,

We should not show the ability to bookmark the app either while looking at a discoverable app

[ppatel9703]

@rameshpaulraj Pls do a investigation prior to passing it off to either fe devs

[kyang4]

For reference, please see this related ticket: SEMOSS/Semoss#701

[samarthKharote]

Recreated the issue, I found
In the SEMOSS UI, users can toggle between My Apps and Discoverable tabs. Within My Apps, users have the ability to bookmark their favorite applications. The issue arises when:
-A user bookmarks one app in My Apps, leaving others unbookmarked.
-The user switches to the "Discoverable" tab.
-Upon returning to the My Apps tab, all apps appear bookmarked, not just the one initially selected.

So far, debugged the backend files which are related to this bug.
While inspecting, I found, there might be a chance of wrong query creation for PROJECTPERMISSION table where logic is putting "favoritesOnly" as "TRUE" for every project/app.
Need to conduct tests with modifying the subquery for the "favoritesOnly" part.

[samarthKharote]

Deeply investigated the bug from backend side. can conclude that the bug is from backend only.
Need to modify setProjectFavorite() part from MyprojectsReactor.Class >> SecurityProjectUtils.Class files

[samarthKharote]

I submitted my modification and raised a PR for it