Skip to content

Bar and Stacked Chart Unfilter Bug #1191

Open
1 of 1 issue completed
Open
Bug
1 of 1 issue completed
@ehynd

Description

@ehynd

A clear and concise description of what the issue is.

I can filter the bar and stacked charts using the brush event. However, I can't unfilter.

How to reproduce the issue

  1. Create two data frames in notebook
  2. Drag in bar chart and create using the first data frame you created in the notebook
  3. Brush to select part of your chart
  4. Right click and select Unfilter

Expected results

Chart will unfilter.

Actual results

Chart is not unfiltering. In this example, I built the stacged bar chart off of a frame called bp_chart_data and the regular bar chart off of a frame called age_gender_pivot.

When I go into network, the RunPixel if I try to unfilter either chart says:

Image

While bp_chart_data is correct, "scatter_average" is the name of the last frame I created within the notebook, not the frame I want to unfilter.

This could not be the issue, but either way, the charts do not unfilter.

Sub-issues

Sub-issues

1 of 1 Issues completed

Activity

added theissue type on May 20, 2025
Shubham009-prog

Shubham009-prog commented on May 27, 2025

@Shubham009-prog
Contributor

Hi Team, I am working on this issue as I can see the bar chart and stacked bar chart share the same context menu component due to which Its not selecting the proper frame. I think we need to create a separate component for both bar and stacked chart.

Shubham009-prog

Shubham009-prog commented on May 29, 2025

@Shubham009-prog
Contributor

Hi @johbaxter,

While investigating this ticket, I discovered that frame.unfilter() always targets the last-used frame by default and does not accept any parameters to specify a different frame. To work around this, I modified the method signature to accept a frameName argument, and verified that the payload is sending the correct frame:

  1. Modified method
    I added a frameName parameter to frame.unfilter() and passed the intended frame on click.

Image

  1. Payload
    The network request payload correctly includes the new frameName.

Image

  1. Response
    The API response still returns the previous frame’s name, so the wrong frame is being un-filtered.

Image

This issue affects all our chart types (bar, stack, etc.), not just this one. When we supply the correct frame in the payload, I would expect the API to unfilter that frame, but it continues to target the last-used frame instead.

Can you help me understand why the frameName parameter isn’t being applied on the back end and suggest how to ensure frame.unfilter() always operates on the frame we specify?

ehynd

ehynd commented on May 30, 2025

@ehynd
Author

@Shubham009-prog let's pause here for a second until John can take a look! can you take a look at #402 again please instead?

Shubham009-prog

Shubham009-prog commented on May 30, 2025

@Shubham009-prog
Contributor

sure

Shubham009-prog

Shubham009-prog commented on Jun 6, 2025

@Shubham009-prog
Contributor

Hi @ehynd, I am moving this ticked to blocked state for now, once the backend will be updated I will move it to the progress state.

rameshpaulraj

rameshpaulraj commented on Jun 6, 2025

@rameshpaulraj

@Shubham009-prog - can you please try to remove the quotes while calling the reactor

Like this - UnfilterFrame(FRAME_33671)

Shubham009-prog

Shubham009-prog commented on Jun 9, 2025

@Shubham009-prog
Contributor

Hi @rameshpaulraj @ehynd, Its working as expected. I will be raising the PR shortly Including the change. Thanks

Shubham009-prog

Shubham009-prog commented on Jun 9, 2025

@Shubham009-prog
Contributor

Hi Team, I have raised the Pull request. Please verify the changes.https://github.com/SEMOSS/semoss-ui/pull/1280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @rameshpaulraj@ehynd@Shubham009-prog@samarthKharote

    Issue actions

      Bar and Stacked Chart Unfilter Bug · Issue #1191 · SEMOSS/semoss-ui