Skip to content

chore(ui5-illustrated-message): migrate wdio tests to cypress #11788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(ui5-illustrated-message): migrate wdio tests to cypress #11788

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
771bd14
chore(ui5-illustrated-message): migrate wdio tests to cypress
NakataCode Jun 24, 2025
ce76cfe
refactor: improve tests
NakataCode Jun 24, 2025
ac73c27
refactor: address comments
NakataCode Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
192 changes: 192 additions & 0 deletions packages/fiori/cypress/specs/IllustratedMessage.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import IllustratedMessage from "../../src/IllustratedMessage.js";
import Label from "@ui5/webcomponents/dist/Label.js";
import "@ui5/webcomponents-fiori/dist/illustrations/AllIllustrations.js"
import Panel from "@ui5/webcomponents/dist/Panel.js";
import Title from "@ui5/webcomponents/dist/Title.js";

describe("Accessibility", () => {
it("should add aria-hidden and role=presetation to the SVG when decorative is true", () => {
Expand Down Expand Up @@ -33,6 +35,35 @@ describe("Accessibility", () => {
.should("not.have.attr", "aria-label");

});

it("content with auto design shrinks to fit the parent container", () => {
const newContainerHeight = 300;
const expectedMedia = "dialog";

cy.mount(
<div id="container" style={{ border: "1px solid #ccc" }}>
<IllustratedMessage id="illustratedMsg5" class="border contentBox">
<button>Action 1</button>
</IllustratedMessage>
</div>
);

cy.get("#container")
.invoke("css", "height", `${newContainerHeight}px`);

cy.get("#illustratedMsg5")
.shadow()
.find(".ui5-illustrated-message-root")
.should(($contents) => {
const scrollHeight = $contents[0].scrollHeight;
const offsetHeight = $contents[0].offsetHeight;
expect(scrollHeight).to.be.lessThan(newContainerHeight);
expect(scrollHeight).to.equal(offsetHeight);
});

cy.get("#illustratedMsg5")
.should("have.prop", "media", expectedMedia);
});
});

describe("design", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all these tests are redundant. they test if attribute is set.

Expand Down Expand Up @@ -77,4 +108,165 @@ describe("design", () => {

});

});

describe("IllustratedMessage 'design' property", () => {
it("should show up properly, when in panel and it expand/collapse", () => {
cy.mount(
<Panel noAnimation>
<IllustratedMessage name="AddColumn" />
</Panel>
);

cy.get("[ui5-panel]")
.invoke("prop", "collapsed", true);

cy.get("[ui5-illustrated-message]")
.should("have.prop", "media", "base");

cy.get("[ui5-panel]")
.invoke("prop", "collapsed", false);

cy.get("[ui5-illustrated-message]")
.should("have.prop", "media")
.and("not.equal", "base");
});
});

describe("Vertical responsiveness", () => {
it("content with auto design shrinks to fit the parent container", () => {
cy.mount(
<div>
<IllustratedMessage />
</div>
);

cy.get("div")
.invoke("css", "height", "300px");

cy.get("[ui5-illustrated-message]")
.shadow()
.find(".ui5-illustrated-message-root")
.should(($contents) => {
const scrollHeight = $contents[0].scrollHeight;
const offsetHeight = $contents[0].offsetHeight;

expect(scrollHeight).to.be.lessThan(300);
expect(scrollHeight).to.equal(offsetHeight);
});
});

it("content with auto design expands to fit the parent container", () => {
cy.mount(
<div>
<IllustratedMessage />
</div>
);

cy.get("div")
.invoke("css", "height", "500px");

cy.get("[ui5-illustrated-message]")
.shadow()
.find(".ui5-illustrated-message-root")
.should(($contents) => {
const scrollHeight = $contents[0].scrollHeight;
const offsetHeight = $contents[0].offsetHeight;
expect(scrollHeight).to.be.lessThan(500);
expect(scrollHeight).to.equal(offsetHeight);
});
});

it("content with fixed design fits the parent container", () => {
cy.mount(
<div>
<IllustratedMessage design="Dialog" />
</div>
);

cy.get("div")
.invoke("css", "height", "250px");

cy.get("[ui5-illustrated-message]")
.shadow()
.find(".ui5-illustrated-message-root")
.should(($contents) => {
const scrollHeight = $contents[0].scrollHeight;
const offsetHeight = $contents[0].offsetHeight;
expect(scrollHeight).to.be.lessThan(250);
expect(scrollHeight).to.equal(offsetHeight);
});
});

it("shows image with unconstrained height when container has auto height", () => {
cy.mount(
<div>
<IllustratedMessage />
</div>
);

cy.get("div")
.invoke("css", "height", "auto");

cy.get("[ui5-illustrated-message]")
.shadow()
.find(".ui5-illustrated-message-illustration svg")
.should("have.css", "height", "240px");
});

it("Illustration visible, when container fit content height", () => {
cy.mount(
<div style={{ height: "440px" }}>
<IllustratedMessage design="Scene" />
</div>
);

cy.get("[ui5-illustrated-message]")
.shadow()
.find(".ui5-illustrated-message-illustration svg")
.should(($illustration) => {
const scrollHeight = $illustration[0].scrollHeight;
expect(scrollHeight).to.not.equal(0);
});
});

it("Illustration visible, when IM slotted and container has fixed height", () => {
cy.mount(
<Panel style={{ height: "19rem" }} noAnimation>
<IllustratedMessage name="AddColumn" />
</Panel>
);

cy.get("[ui5-illustrated-message]")
.shadow()
.find(".ui5-illustrated-message-illustration svg")
.should(($illustration) => {
const scrollHeight = $illustration[0].scrollHeight;
expect(scrollHeight).to.not.equal(0);
});
});
});

describe("Dot design resource handling", () => {
it("uses substitute Spot illustration", () => {
cy.mount(
<IllustratedMessage name="TntUnableToLoad" design="Dot" />
);

cy.get("[ui5-illustrated-message]")
.shadow()
.find(".ui5-illustrated-message-illustration svg")
.should("have.id", "tnt-Spot-UnableToLoad");
});

it("uses original Dot illustration", () => {
cy.mount(
<IllustratedMessage name="AddPeople" design="Dot" />
);

cy.get("[ui5-illustrated-message]")
.shadow()
.find(".ui5-illustrated-message-illustration svg")
.should("have.id", "sapIllus-Dot-AddPeople");
});
});
Loading